Here is the proposed code change
http://cr.openjdk.java.net/~weijun/999/webrev.jgss.cleanup/
Please take a review.
Thanks
Max
> On Jun 6, 2018, at 11:04 AM, Weijun Wang wrote:
>
> module-info.java in java.base and java.security.jgss look fine.
>
> There are other codes in java.securit
RandomCookie.java:
+private boolean isT12Downgrade() {
+return Arrays.equals(randomBytes, 24, 31, t12Protection, 0, 7);
+}
+
+private boolean isT11Downgrade() {
+return Arrays.equals(randomBytes, 24, 31, t11Protection, 0, 7);
+}
The "to" in Arrays::equals is exclus
> On 6/5/2018 6:54 AM, Weijun Wang wrote:
>> HelloCookieManager.java:
>> 44 HelloCookieManager(SecureRandom secureRandom) {
>> 45 this.secureRandom = secureRandom;
>> 46 }
>> 47
>> 48 HelloCookieManager valueOf(ProtocolVersion protocolVersion) {
>> Why not just creat
module-info.java in java.base and java.security.jgss look fine.
There are other codes in java.security.jgss related to the JSSE krb5
ciphersuites. Do you want me to add a chanegset to the sandbox for a cleanup?
Thanks
Max
>
>
>
>> On Jun 5, 2018, at 12:12 PM, Xuelei Fan wrote:
>>
>>> http:
Update: http://hg.openjdk.java.net/jdk/sandbox/rev/ec5537b61038
Note that the above changeset will be included in next webrev for
further code review.
On 6/5/2018 6:54 AM, Weijun Wang wrote:
HelloCookieManager.java:
44 HelloCookieManager(SecureRandom secureRandom) {
45 this
Hi Bernd,
I do have some perf numbers, but I haven't done a lot of comparisons yet
against other algs like AES-GCM and CBC. It would be a good idea to get
those numbers before I release what I have so far.
--Jamil
On 6/5/2018 1:38 AM, Bernd Eckenfels wrote:
Jamil, I was wandering if you hav
HelloCookieManager.java:
44 HelloCookieManager(SecureRandom secureRandom) {
45 this.secureRandom = secureRandom;
46 }
47
48 HelloCookieManager valueOf(ProtocolVersion protocolVersion) {
Why not just create a static method and make HelloCookieManager abstract?
Jamil, I was wandering if you have performance test numbers to share yet? Do
you have an internal acceptance criteria for it? Do we expect it to beat
unaccelerated AES256-GCM or come close to CBC performance?
Gruss
Bernd
--
http://bernd.eckenfels.net
From: securi
