Hi Valerie,
All good catches! I made a code clean up in the update:
http://hg.openjdk.java.net/jdk/sandbox/rev/38c2a4078033
Thanks,
Xuelei
On 6/8/2018 5:16 PM, Valerie Peng wrote:
Hi Xuelei,
Will this.requestedServerNames ever be null? This field is initialized
in constructors with Col
On 06/08/2018 07:55 PM, Bradford Wetmore wrote:
[...]
TransportContext.java
-
90: Any chance of combining these 3 constructors into 1? Almost
identical duplicate code here.
I have some code to change this already.
Tony
Update: http://hg.openjdk.java.net/jdk/sandbox/rev/2d7e08d730b6
On 6/7/2018 7:36 PM, Bradford Wetmore wrote:
I'm working my way through CipherSuite.java, slow going as I'm making
sure all of the ciphersuites got updated to the new format.
SSLServerSocketFactoryImpl.java
-
Some comments on SSLLogger also :
formatCaller() uses getStackTrace() to walk the stack. It's probably
more expensive than using the newer Stackwalker class. Could it be
replaced with something like :
return StackWalker.getInstance().walk(s ->
s.dropWhile((f ->
f.g
