Hi Xuelei,
These look fine.
- kind of strange to see SSLKeyAgreement extends
SSLKeyAgreementGenerator... Normally, the naming convention implies one
generates the other.
- same method name as in SSLKeyDerivationGenerator. I assume that this
is intentional as both are meant to derive
Sorry for resending it. I missed a few MLs.
--
Hi,
Please, could I get comments on the following change?
Since it's related to security, I would be glad if security
experts could also comment on that.
webrev: http://cr.openjdk.java.net/~gromero/POWER9/darn/v6_rebased/
It introduces a way to
Read side key limit change at:
http://hg.openjdk.java.net/jdk/sandbox/rev/6210466cf1ac
Tony
Hi Xuelei,
Just questions and some nits.
looks good
looks good
- line 98: for unsupported digest, maybe we should consider throw
exceptions. It's easier to find out where the support needs to be added
if we fail early.
- Just wondering why we need difference classes of
SecretKeyDeriva
ECPointFormatsExtension.java
PredefinedDHParameterSpecs.java
SSLAlgorithmConstraints.java
SSLAlgorithmDecomposer.java
---
Looks fine to me, except the copyright year of
PredefinedDHParameterSpecs and SSLAlgorithmDecomposer. Updated in the
following changeset.
http:
