Re: RFR 8202299: Java Keystore fails to load PKCS12/PFX certificates created in WindowsServer2016

Thanks for the code review. My feeling is that this is a very good chance to use functional programming, where a repeated pattern is abstracted to a general method that calls independent actions. I'd choose webrev.01. --Max > On Jun 26, 2018, at 10:25 AM, Xuelei Fan wrote: > > Looks fine to

Re: RFR 8202608: CommonSeeder test needs a white-box testing mechanism to replace the default entropy source

Looks fine to me. Thanks, Xuelei On 6/24/2018 6:22 PM, Weijun Wang wrote: Please take a review at http://cr.openjdk.java.net/~weijun/8202608/webrev.00/ I added a patched SeedGenerator and remove the reflection calls. A comment in AbstractDrbg.java removed. That's not a trusted

Re: RFR 8202299: Java Keystore fails to load PKCS12/PFX certificates created in WindowsServer2016

Looks fine to me. webrev.00 looks more straightforward to me. I did not see too much benefit to use functional programming in webrev.01. I will let you make the final decision. Xuelei On 5/17/2018 9:00 PM, Weijun Wang wrote: Seems more complicated and harder to understand that code.

Re: RFR 8203228: Branch-free output conversion for X25519 and X448

The change looks fine to me Tony On 06/25/2018 05:49 AM, Adam Petcher wrote: It would be nice to get this X25519/X448 enhancement into JDK 11. If anyone has some time to review this in the next day or so, I would appreciate it. On 5/15/2018 2:42 PM, Adam Petcher wrote: Webrev:

Re: RFR: 8148188: Enhance the security libraries to record events of interest

Many thanks for the review comments Erik. Replies inline. On 24/06/2018 14:21, Erik Gahlin wrote: Hi Sean, Some of the changes in the webrev belongs to JDK-8203629 and should be removed for clarity. Some initial comments: default.jfc, profile.jfr: The events should not have

Re: RFR 8205445: Add RSASSA-PSS Signature support to SunMSCAPI

Great, that's good then. Valerie On 6/22/2018 5:40 PM, Weijun Wang wrote: On Jun 23, 2018, at 8:35 AM, Valerie Peng wrote: On 6/22/2018 3:23 PM, Weijun Wang wrote: On Jun 23, 2018, at 2:30 AM, Valerie Peng wrote: Max, Good catch on the SunRsaSign provider bug. Looking at the changes,

Re: [11]RFR 8196213: sun/security/tools/jarsigner/warnings/NoTimestampTest.java test fails on ar_SA locale.

Looks good. Naoto On 6/25/18 12:04 AM, Dora Zhou wrote: Hello, Please help review the fix for JDK-8196213. Thank you. Set default locale to en-US so that the output display the date using Gregorian Calendar and Latn numbering system(0~9). Bug:

Re: [11]RFR 8194152: sun/security/tools/jarsigner/AltProvider.java failed on de-DE locale

Looks good. Naoto On 6/25/18 12:37 AM, Dora Zhou wrote: Hi Naoto, Thanks a lot for the review. I have made suggested changes, Kindly have a look at: http://cr.openjdk.java.net/~ljiang/8194152/webrev.01/ Regards, Dora From:

Re: Code Review Request: TLS 1.3 Implementation

Update: http://hg.openjdk.java.net/jdk/sandbox/rev/32a737f51e37 Xuelei On 6/18/2018 8:48 AM, Xuelei Fan wrote: CertificateMessage.java X509TrustManagerImpl.java X509KeyManagerImpl.java - These implementation has not consider the impact of RSASSA-PSS key type. Xuelei

Re: RFR 8203228: Branch-free output conversion for X25519 and X448

It would be nice to get this X25519/X448 enhancement into JDK 11. If anyone has some time to review this in the next day or so, I would appreciate it. On 5/15/2018 2:42 PM, Adam Petcher wrote: Webrev: http://cr.openjdk.java.net/~apetcher/8203228/webrev.00/ Please review the change for this

RFR[11] JDK-8203007: Address missing block coverage for ChaCha20 and Poly1305 algorithms

Hi, This patch introduces three new tests to enhance code coverage for ChaCha20 and Poly1305 algorithms. Issue: https://bugs.openjdk.java.net/browse/JDK-8203007 Webrev: http://cr.openjdk.java.net/~jjiang/8203007/webrev.00/ Best regards, John Jiang

Re: [11]RFR 8194152: sun/security/tools/jarsigner/AltProvider.java failed on de-DE locale

Hi Naoto, Thanks a lot for the review. I have made suggested changes, Kindly have a look at: http://cr.openjdk.java.net/~ljiang/8194152/webrev.01/ Regards, Dora From: naoto.s...@oracle.com To: dan.z.z...@oracle.com,

[11]RFR 8196213: sun/security/tools/jarsigner/warnings/NoTimestampTest.java test fails on ar_SA locale.

Hello, Please help review the fix for JDK-8196213. Thank you. Set default locale to en-US so that the output display the date using Gregorian Calendar and Latn numbering system(0~9). Bug: https://bugs.openjdk.java.net/browse/JDK-8196213 Webrev: