On 8202598: [linux] keytool -certreq inconsistent with platform line.separator

2018-06-26 Thread Weijun Wang
Hi Severin and/or Andrew I'm going through all security bugs with JDK 11 in affected versions and noticed this one: 8202598: [linux] keytool -certreq inconsistent with platform line.separator https://bugs.openjdk.java.net/browse/JDK-8202598 What kind of interop issue have you observed? IM

Re: RFR: 8148188: Enhance the security libraries to record events of interest

2018-06-26 Thread Seán Coffey
Erik, I rebased the patch with TLS v1.3 integration today. I hadn't realized how much the handshaker code had changed. Hopefully, I'll get a review from security dev team on that front. Regards the JFR semantics, I believe the edits should match majority of requests . I still have a preferen

Re: [11] RFR: JDK-8205111: Develop new Test to verify different key types for supported TLS protocols.

2018-06-26 Thread Xuelei Fan
Looks fine to me. Thanks, Xuelei On 6/26/2018 12:09 AM, Sibabrata Sahoo wrote: Hi Xuelei, Please review the updated webrev: http://cr.openjdk.java.net/~ssahoo/8205111/webrev.01/ - Now rsa_pss_pss* uses " DHE or ECDHE_RSA " ciphers for TLSv1.2 which is working fine now. - Additional code add

Re: [11] RFR 8205673: Problem list RmiRegistrySslTest.java and RmiSslBootstrapTest.sh

2018-06-26 Thread Xuelei Fan
Looks fine to me. Thanks, Xuelei > On Jun 26, 2018, at 2:20 AM, Amy Lu wrote: > > sun/management/jmxremote/bootstrap/RmiSslBootstrapTest.sh > sun/management/jmxremote/bootstrap/RmiRegistrySslTest.java > > Above two tests have been failing on all platforms (JDK-8205653) since > JDK-8196584. >

Re: RFR [11] 8205671: Remove HTTP Client tests erroneously problem listed by the TLS 1.3 integration

2018-06-26 Thread Michael McMahon
Looks good Chris. - Michael. On 26/06/2018, 11:45, Chris Hegarty wrote: Seems that the integration of TLS 1.3 erroneously added a number of HTTP Client tests to the ProblemList. Previous to the TLS 1.3 push, work was done to ensure that the HTTP Client tests ran successfully with the changes

Re: RFR [11] 8205671: Remove HTTP Client tests erroneously problem listed by the TLS 1.3 integration

2018-06-26 Thread Daniel Fuchs
Looks good to me Chris. best, -- daniel On 26/06/2018 11:45, Chris Hegarty wrote: Seems that the integration of TLS 1.3 erroneously added a number of HTTP Client tests to the ProblemList. Previous to the TLS 1.3 push, work was done to ensure that the HTTP Client tests ran successfully with th

RFR [11] 8205671: Remove HTTP Client tests erroneously problem listed by the TLS 1.3 integration

2018-06-26 Thread Chris Hegarty
Seems that the integration of TLS 1.3 erroneously added a number of HTTP Client tests to the ProblemList. Previous to the TLS 1.3 push, work was done to ensure that the HTTP Client tests ran successfully with the changes in the TLS 1.3 branch. These tests should not have been problem listed. di

[11] RFR 8205673: Problem list RmiRegistrySslTest.java and RmiSslBootstrapTest.sh

2018-06-26 Thread Amy Lu
sun/management/jmxremote/bootstrap/RmiSslBootstrapTest.sh sun/management/jmxremote/bootstrap/RmiRegistrySslTest.java Above two tests have been failing on all platforms (JDK-8205653) since JDK-8196584. Please review the patch to add these tests to ProblemList.txt until a full fix is developed.

RE: [11] RFR: JDK-8205111: Develop new Test to verify different key types for supported TLS protocols.

2018-06-26 Thread Sibabrata Sahoo
Hi Xuelei, Please review the updated webrev: http://cr.openjdk.java.net/~ssahoo/8205111/webrev.01/ - Now rsa_pss_pss* uses " DHE or ECDHE_RSA " ciphers for TLSv1.2 which is working fine now. - Additional code added for " read/write " after re-handshake. John, - PKCS12 used instead of JKS. - Co