Comments inline.
On 28/06/2018 17:20, Erik Gahlin wrote:
It's sufficient if an event object escapes to another method
(regardless if JFR is enabled or not).
Some more feedback:
Rename event jdk.CertChain to jdk.CertificateChain
Rename event jdk.X509Cert to jdk.X509Certificate
Rename field ce
It's sufficient if an event object escapes to another method (regardless
if JFR is enabled or not).
Some more feedback:
Rename event jdk.CertChain to jdk.CertificateChain
Rename event jdk.X509Cert to jdk.X509Certificate
Rename field certChain to certificateChain.
Rename field serialNum to seria
Hi Martin,
The TLS 1.3 implementation was integrated into the mainline.
I know you have multiple contributions were pending because of the
re-org of the JSSE implementation. Would you mind to check if your
design and implementation need some adjustment?
I may not reply for your contribution
Hi Siba,
The change looks fine to me. I would like Serviceability review this
change as well.
Thanks,
Xuelei
On 6/28/2018 8:46 AM, Daniel Fuchs wrote:
[ccing serviceability-...@openjdk.java.net]
Hi Siba,
This looks good to me - but I'm not a SSL expert.
It would be good to get someone fro
RDP1 started on 15:00 UTC. I'll push to jdk/jdk11 when it's ready.
--Max
> On Jun 28, 2018, at 11:27 PM, Sean Mullan wrote:
>
> Looks fine.
>
> --Sean
>
> On 6/27/18 10:20 AM, Weijun Wang wrote:
>> Please take a review at
>>http://cr.openjdk.java.net/~weijun/8205927/webrev.00/
>> I missed
[ccing serviceability-...@openjdk.java.net]
Hi Siba,
This looks good to me - but I'm not a SSL expert.
It would be good to get someone from the security team eyeball those
changes (Xuelei? Brad?)
I added serviceability-...@openjdk.java.net in cc as this is where
reviews for JMX/Monitoring chang
Looks fine.
--Sean
On 6/27/18 10:20 AM, Weijun Wang wrote:
Please take a review at
http://cr.openjdk.java.net/~weijun/8205927/webrev.00/
I missed a date and a link when pushing the change for JDK-8201815. Also, the
latest MPL 2.0 uses https now.
Thanks
Max
Resending the email after subscribing to HYPERLINK
"mailto:jmx-...@openjdk.java.net"jmx-...@openjdk.java.net
Thanks,
Siba
From: Sibabrata Sahoo
Sent: Thursday, June 28, 2018 8:40 PM
To: HYPERLINK "mailto:jmx-...@openjdk.java.net"jmx-...@openjdk.java.net;
HYPERLINK "mailto:security-dev@o
Hi Daniel,
I am not a member of HYPERLINK
"mailto:jmx-...@openjdk.java.net"jmx-...@openjdk.java.net. So the review posted
is waiting for moderator's approval.
Thanks,
Siba
From: Sibabrata Sahoo
Sent: Thursday, June 28, 2018 8:40 PM
To: jmx-...@openjdk.java.net; security-dev@openjdk.
Hi,
Please review the patch for,
JBS: https://bugs.openjdk.java.net/browse/JDK-8205653
Webrev: http://cr.openjdk.java.net/~ssahoo/8205653/webrev.00/
Change:
The Test has been upgraded to address the following 2 cases,
Add protocol support for TLSv1.3. The change is done in the config
Looks fine to me. Thanks!
Xuelei
On 6/28/2018 5:28 AM, Seán Coffey wrote:
Thanks for reviewing Xuelei,
I do acknowledge that the new TLS v1.3 code has greatly improved the
logging output for related operations. I think the main drive with this
enhancement is to use the new JFR API to captur
Thanks for the update Erik. By default I'm proposing that the new JFR
Events and Logger be disabled. As a result the event class shouldn't
escape. If performance metrics highlight an issue, we should revisit.
regards,
Sean.
On 27/06/2018 20:57, Erik Gahlin wrote:
On 2018-06-27 21:14, Seán Co
Thanks for reviewing Xuelei,
I do acknowledge that the new TLS v1.3 code has greatly improved the
logging output for related operations. I think the main drive with this
enhancement is to use the new JFR API to capture interesting events. We
can revisit the Logger requirements if there's a str
13 matches
Mail list logo
