Re: RFR - 8203614: Java API SSLEngine example code needs correction

Looks good. Brad On 8/17/2018 5:53 PM, Anthony Scarpino wrote: Looks fine. Tony On Aug 17, 2018, at 8:45 AM, Jamil Nimeh wrote: Hello all, This is a simple doc-only one-liner that fixes the sample code in SSLEngine to use the correct ByteBuffer in the capacity size check. webrev: http:

Re: RFR - 8203614: Java API SSLEngine example code needs correction

Looks fine. Tony > On Aug 17, 2018, at 8:45 AM, Jamil Nimeh wrote: > > Hello all, > > This is a simple doc-only one-liner that fixes the sample code in SSLEngine > to use the correct ByteBuffer in the capacity size check. > > webrev: http://cr.openjdk.java.net/~jnimeh/reviews/8203614/webrev

Re: [12] RFR 8193859: Allow user provided ObjectInputFilter in SealedObject and SignedObject

Look fine. Thanks, Roger On 8/17/18 10:56 AM, Weijun Wang wrote: Please take a review at the updated webrev at http://cr.openjdk.java.net/~weijun/8193859/webrev.01 Changes only in doc, including 1) The "2018-8-15 updates" in the CSR [1] 2) formatting Thanks Max [1] https://bugs.openjd

RFR - 8203614: Java API SSLEngine example code needs correction

Hello all, This is a simple doc-only one-liner that fixes the sample code in SSLEngine to use the correct ByteBuffer in the capacity size check. webrev: http://cr.openjdk.java.net/~jnimeh/reviews/8203614/webrev.01/ JBS: https://bugs.openjdk.java.net/browse/JDK-8203614 Thanks, --Jamil

Re: [12] RFR 8193859: Allow user provided ObjectInputFilter in SealedObject and SignedObject

Please take a review at the updated webrev at http://cr.openjdk.java.net/~weijun/8193859/webrev.01 Changes only in doc, including 1) The "2018-8-15 updates" in the CSR [1] 2) formatting Thanks Max [1] https://bugs.openjdk.java.net/browse/JDK-8193887 > On Aug 14, 2018, at 11:19 PM, Roger R

Re: RFR: JDK-8208675: Remove legacy sun.security.key.serial.interop property

Looks good. --Sean On 8/17/18 5:13 AM, Seán Coffey wrote: "sun.security.key.serial.interop" is an old JDK 1.4 -1.5 interoperability property. It can be safely removed now. JBS report : https://bugs.openjdk.java.net/browse/JDK-8208675 webrev : http://cr.openjdk.java.net/~coffeys/webrev.8208675

Re: RFR[11]: release note for JDK-7007966 "Add Brainpool ECC support (RFC 5639)"

No more suggestions. Looks good to me. On 8/16/2018 9:27 PM, Valerie Peng wrote: Sure, I've updated the release note. Please let me know if you have other suggestions/feedbacks. https://bugs.openjdk.java.net/browse/JDK-8208580 Thanks, Valerie On 8/16/2018 8:10 AM, Adam Petcher wrote: T

RFR: JDK-8208675: Remove legacy sun.security.key.serial.interop property

"sun.security.key.serial.interop" is an old JDK 1.4 -1.5 interoperability property. It can be safely removed now. JBS report : https://bugs.openjdk.java.net/browse/JDK-8208675 webrev : http://cr.openjdk.java.net/~coffeys/webrev.8208675/webrev/ regards, Sean.