I might be a little too quick saying "I will".
The current class spec has
* In this example, an {@link ObjectInputFilter} is used during
* deserialization of the original object. If {@link #getObject()} is
* called, the {@link ObjectInputFilter.Config#getSerialFilter()
* system filter} is used in
Looks good to me.
Xuelei
On 8/20/2018 5:06 PM, Bradford Wetmore wrote:
On 8/20/2018 4:28 PM, Xue-Lei Fan wrote:
SSLTransport.java
-
line 173, nice to have 4 more indent white spaces.
Ok, I could go either way on this one.
SSLEngineImpl.java
--
942 // I
On 8/20/2018 4:28 PM, Xue-Lei Fan wrote:
SSLTransport.java
-
line 173, nice to have 4 more indent white spaces.
Ok, I could go either way on this one.
SSLEngineImpl.java
--
942 // If it wasn't a RuntimeException/SSLException, need to wrap it.
943 if
SSLTransport.java
-
line 173, nice to have 4 more indent white spaces.
SSLEngineImpl.java
--
942 // If it wasn't a RuntimeException/SSLException, need to wrap it.
943 if (!(exc instanceof RuntimeException) &&
944 !(exc instanceof SSLException)) {
> On Aug 21, 2018, at 2:06 AM, Sean Mullan wrote:
>
> The SealedObjectFilter and SignedObjectFilter tests are almost the same,
> maybe they should be combined?
I had thought about it but SignedObjectFilter.java is in jdk_security2 and
SealedObjectFilter.java is in jdk_security1. I'm afraid
Intentional.
Very minor things.
Brad
On 8/20/2018 3:04 PM, Anthony Scarpino wrote:
On 08/20/2018 01:33 PM, Bradford Wetmore wrote:
Hi Xuelei,
Please review this P1 bug blocking JDK11 RC:
https://bugs.openjdk.java.net/browse/JDK-8207317
http://cr.openjdk.java.net/~wetmore/820731
On 08/20/2018 01:33 PM, Bradford Wetmore wrote:
Hi Xuelei,
Please review this P1 bug blocking JDK11 RC:
https://bugs.openjdk.java.net/browse/JDK-8207317
http://cr.openjdk.java.net/~wetmore/8207317/webrev.00/
Proposed putback comment is inlined in the webrev.
Bug analysis/fix explan
Hi Xuelei,
Please review this P1 bug blocking JDK11 RC:
https://bugs.openjdk.java.net/browse/JDK-8207317
http://cr.openjdk.java.net/~wetmore/8207317/webrev.00/
Proposed putback comment is inlined in the webrev.
Bug analysis/fix explanation is in the last comment of the bug.
Brad
The SealedObjectFilter and SignedObjectFilter tests are almost the same,
maybe they should be combined? Also, can you add a test to check that a
SecurityException is thrown when an SM is enabled and the
SerializablePermission("serialFilter") has not been granted?
- SignedObject
69 * called
Looks fine to me.
Thanks,
Xuelei
On 8/20/2018 10:42 AM, Jamil Nimeh wrote:
Hello all, updated webrev:
* Copyright and comment fixes
* Leaving NoDesRC4CiphSuite.java in othervm mode per Xuelei's concerns
* Changed output to use System.err so it outputs on the same stream as
SSLLogger.
Hello all, updated webrev:
* Copyright and comment fixes
* Leaving NoDesRC4CiphSuite.java in othervm mode per Xuelei's concerns
* Changed output to use System.err so it outputs on the same stream as
SSLLogger.
http://cr.openjdk.java.net/~jnimeh/reviews/8208350/webrev.02
Thanks,
--Jamil
NoDesRC4CiphSuite.java
--
Please move line 30-31 out of the test comment block. The two lines
will be parsed as part of the run parameters.
I would prefer to use othervm mode. Otherwise, once there is a test
case does not run with othervm and changes the context, this tes
I can fix the copyright, no problem. Good catch on the othervm - the
original form of the test did set properties but it seemed better to not
set them explicitly and just use the new defaults. One would not expect
to ever remove DES and RC4 from the disabledAlgorithms identifier set,
at least
Looks good, just a few minor comments:
CustomizedCipherSuites.java
- should have both years (2016, 2018) on copyright
NoDesRC4CiphSuite.java
- does this need to be run in othervm mode? It doesn't look like you are
setting any properties dynamically. Lines 30-31 should also be removed,
if so.
14 matches
Mail list logo
