Re: RFR: 8148188: Enhance the security libraries to record events of interest

2018-11-13 Thread Weijun Wang
Confused. Aren't all Security properties security-related? This is not about normal system properties. And the method name in the latest webrev is "isSecurityProperty" without the "JDK" word. I assume this means you don't care about the difference between SE properties and JDK properties. --Ma

Re: RFR 8213400: Support choosing curve name in keytool keypair generation

2018-11-13 Thread Weijun Wang
Thanks. Please also take a look at the release note at https://bugs.openjdk.java.net/browse/JDK-8213821. --Max > On Nov 13, 2018, at 11:02 PM, Adam Petcher wrote: > > This change looks good to me. Thanks. >

Re: RFR: 8148188: Enhance the security libraries to record events of interest

2018-11-13 Thread Sean Mullan
Looking good, a couple of comments/questions: * src/java.base/share/classes/java/security/Security.java The isJdkSecurityProperty method could return false positives, for example there may be a non-JDK property starting with "security.". I was thinking it would be better to put all the JDK pro

Re: RFR, JDK-8212885: TLS 1.3 resumed session does not retain peer certificate chain

2018-11-13 Thread Xuelei Fan
Looks fine to me. Thanks, Xuelei On 11/12/2018 11:46 PM, Jamil Nimeh wrote: Hello all, This is an update that addresses a few additional fields that needed to be carried over into the new SSLSession, as well as adding some more testing on the retrieved resumed SSLSession object. http://cr.

Re: RFR 8213400: Support choosing curve name in keytool keypair generation

2018-11-13 Thread Adam Petcher
This change looks good to me. Thanks. On 11/11/2018 8:08 PM, Weijun Wang wrote: Webrev updated at https://cr.openjdk.java.net/~weijun/8213400/webrev.01/ Please review again. I've removed the change to CurveDB and NamedCurve. The test now simply looks at key.getParams().toString(). This i