Re: RFR: 8210838: Override javax.crypto.Cipher.toString()

The version looks fine. Thanks. > On Nov 17, 2018, at 1:56 AM, Seán Coffey wrote: > > Thanks Sean. StringBuilder use added : > > http://cr.openjdk.java.net/~coffeys/webrev.8210838.v4/webrev/ > > Regards, > Sean. > > On 16/11/18 17:33, Sean Mullan wrote: >> Looks ok. If there are no disadvanta

Re: RFR 8212003: Obsoleting the default keytool -keyalg option

https://bugs.openjdk.java.net/browse/JDK-8214024 filed. Thanks Max > On Nov 17, 2018, at 3:56 AM, Sean Mullan wrote: > > Looks good. Please file a follow-on issue to remove the defaults. > > --Sean > > On 11/16/18 9:35 AM, Weijun Wang wrote: >> Please take a review at >>https://cr.openjdk