RFR 6722928: Support SSPI as a native GSS-API provider

2018-11-19 Thread Weijun Wang
Please take a review at https://cr.openjdk.java.net/~weijun/6722928/webrev.01/ We ported [1] the native GSS bridge to Windows in JDK 11, but user still have to download and install a native GSS-API library. This code change provides a native GSS-API library inside JDK that can be used withou

Re: RFR 8213202: Possible race condition in TLS 1.3 session resumption

2018-11-19 Thread Jamil Nimeh
Hi Adam, I think this looks good. On 11/9/2018 11:09 AM, Adam Petcher wrote: JBS: https://bugs.openjdk.java.net/browse/JDK-8213202 webrev: http://cr.openjdk.java.net/~apetcher/8213202/webrev.00/ This change fixes a bug that allows multiple clients thread to offer the same PSK to the server, e

Re: RFR(S)JDK-8214074: Ghash optimization using AVX instructions

2018-11-19 Thread Bernd Eckenfels
Hello, What is the purpose of setting some of them to 0 twice? (It’s a new array which should be all-0 anyway.) + for (int i = 1; i < 9 ; i++) { +subkeyHtbl[2*i] = 0; +subkeyHtbl[2*i+1] = 0; +} Also, is the subkeyH no longer be needed (or can be redesigned t

Re: Code Review Request, JDK-8213577, Update the default SSL session cache size to 20480

2018-11-19 Thread Sean Mullan
On 11/16/18 3:19 PM, Xuelei Fan wrote: Thanks for the review, Jmail & Sean. New webrev:     http://cr.openjdk.java.net/~xuelei/8210985/webrev.03/ I will update CSR when we come to an agreement. On 11/16/2018 11:33 AM, Sean Mullan wrote:   122  * @apiNote Both the session timeout and cache