Thanks for the update. No more comments.
Xuelei
On 1/17/2019 3:42 PM, sha.ji...@oracle.com wrote:
Hi Xuelei,
On 2019/1/18 02:00, Xuelei Fan wrote:
Hi John,
Looks fine to me except a minor format comment.
Would you mind check the line length and limit to 80 characters each
line?
For exam
> On Jan 18, 2019, at 2:22 AM, Sean Mullan wrote:
>
> This is a nice cleanup. Just a couple of comments:
>
> - Update copyrights now that it is 2019
Will change.
>
> - For the test, is the source code always guaranteed to be there? I was not
> sure if that was a requirement. Or does the t
Hi Xuelei,
On 2019/1/18 02:00, Xuelei Fan wrote:
Hi John,
Looks fine to me except a minor format comment.
Would you mind check the line length and limit to 80 characters each
line?
For example, using "\" join multiple lines together.
// openssl req -x509 -new -key key.pem \
//
To address some concerns raised during the CSR [1] review, I have
adjusted the proposed wording to recommend that, as a best practice (and
not as a requirement), implementations should use standard names for
additional algorithms that they choose to support if those standard
names are defined i
Hello!
Would you please help review a trivial fix to avoid a possible
arithmetic overflow in comparison?
BUGURL: https://bugs.openjdk.java.net/browse/JDK-8217344
WEBREV: http://cr.openjdk.java.net/~igerasim/8217344/00/webrev/
Thanks in advance!
--
With kind regards,
Ivan Gerasimov
On Thu, Jan 17, 2019 at 11:19:14PM +0800, Weijun Wang wrote:
> Webrev updated at
>
>https://cr.openjdk.java.net/~weijun/6722928/webrev.03
>
> Changes since webrev.02:
>
> - gss_name_struct, gss_ctx_id_struct, and gss_cred_id_struct defined and
> gssapi.h is updated to use them to define po
This is a nice cleanup. Just a couple of comments:
- Update copyrights now that it is 2019
- For the test, is the source code always guaranteed to be there? I was
not sure if that was a requirement. Or does the test still pass if it
can't find the source code?
Thanks,
Sean
On 12/27/18 3:11
Looks good to me Sean.
regards,
Sean.
On 16/01/2019 19:53, Sean Mullan wrote:
Please review this change to allow a later Symantec Policy distrust
date for two Apple subordinate CAs.
webrev: http://cr.openjdk.java.net/~mullan/webrevs/8216280/webrev.00/
bug: https://bugs.openjdk.java.net/browse
Hi John,
Looks fine to me except a minor format comment.
Would you mind check the line length and limit to 80 characters each line?
For example, using "\" join multiple lines together.
// openssl req -x509 -new -key key.pem \
// -subj "/CN=RSA-2048-SHA256" -sha256 -out cer.pem
Tha
Good Morning, Alan.
Added the -Djavax.net.debug=all option to my Wildfly startup and waited
for the pool to close a connection to MySql at AWS.
TXT file attached.
javac 11.0.1
mysql jdbc driver 8.0.13
wildfly 15.0.1
--drg
Webrev updated at
https://cr.openjdk.java.net/~weijun/6722928/webrev.03
Changes since webrev.02:
- gss_name_struct, gss_ctx_id_struct, and gss_cred_id_struct defined and
gssapi.h is updated to use them to define pointer types gss_name_t,
gss_cred_id_t, and gss_ctx_id_t.
- small bug found i
Hi,
The patch adds TLS 1.3 cases for test
javax/net/ssl/compatibility/Compatibility.java.
Beside this enhancement, it also changes the test on the following points:
1. Re-generate all certificates to use key size 2048 and SHA256 rather
than 1024 and SHA1. And new RSA signed EC key certificates
12 matches
Mail list logo
