Re: JDK-8215102 (Follow-up)

2019-01-24 Thread Jaikiran Pai
Hello Severin, Thank you for spending time on this. Although that JIRA was raised for in context of MySQL driver, having watched this discussion and looked a bit into the exception stacktrace, I think it's not really specific to MySQL. So I decided to reproduce this with just plain Java

RE: RFR 8217657: Move the test for default value of jdk.includeInExceptions into own test

2019-01-24 Thread Langer, Christoph
Hi Sean, thanks for looking at this. I agree. Will remove othervm... Best regards Christoph > -Original Message- > From: Sean Mullan > Sent: Donnerstag, 24. Januar 2019 17:43 > To: Langer, Christoph ; OpenJDK Dev list > ; OpenJDK Network Dev list d...@openjdk.java.net> > Subject: Re:

Re: JDK-8215102 (Follow-up)

2019-01-24 Thread Severin Gehwolf
Hi, Thanks for your feedback! I've tried to reproduce this on my end too, but failed. At least with MariaDB 10.2.21 and their recent jdbc driver and JDK 11. This looks like a JDBC driver issue on newer JDKs. Hence, I've noted that in the bug and closed it:

Re: RFR 8217657: Move the test for default value of jdk.includeInExceptions into own test

2019-01-24 Thread Sean Mullan
I don't think you really need to run the test with the othervm flag, unless you are concerned other tests may be setting this property and (incorrectly) not running in a separate VM, which would be a bug in my opinion. Well, then maybe you should run it in othervm just in case. Otherwise,

RE: RFR 8217657: Move the test for default value of jdk.includeInExceptions into own test

2019-01-24 Thread Lindenmaier, Goetz
Thanks! I should have stated that I don't need a new webrev, thanks anyways. Best regards, Goetz. > -Original Message- > From: Langer, Christoph > Sent: Donnerstag, 24. Januar 2019 11:59 > To: Lindenmaier, Goetz ; OpenJDK Dev list > ; OpenJDK Network Dev list d...@openjdk.java.net> >

RE: RFR 8217657: Move the test for default value of jdk.includeInExceptions into own test

2019-01-24 Thread Langer, Christoph
Hi Goetz, thanks for the review. I've added the comment as you suggested: http://cr.openjdk.java.net/~clanger/webrevs/8217657.1/ Will run it through our nightly tests before submitting... /Christoph From: Lindenmaier, Goetz Sent: Donnerstag, 24. Januar 2019 08:48 To: Langer, Christoph ;