Re: XML Digital Signature throws NAMESPACE_ERR exception under OpenJDK 11 that works under Java SE 8, 9 and 10

2019-02-15 Thread Open eSignForms
That seems to work, though I used this code instead: qualifyingPropertiesElement.setAttributeNS("http://www.w3.org/2000/xmlns/","xmlns:xades";, "http://uri.etsi.org/01903/v1.4.1#";); That's because my xades elements all carry that prefix.  It does seem to work.  It's a bit odd to have to code

RFR: 8159525: Add @FunctionalInterface annotation to PrivilegedAction and PrivilegedExceptionAction

2019-02-15 Thread Sean Mullan
This probably should have been done a while ago, but these interfaces are both good examples of functional interfaces, so adding the annotation is still justified (and simple). CSR: https://bugs.openjdk.java.net/browse/JDK-8219145 (Diffs are also in the CSR). Thanks, Sean

Re: RFR 6722928: Support SSPI as a native GSS-API provider

2019-02-15 Thread Nico Williams
On Tue, Jan 22, 2019 at 10:52:59AM +0800, Weijun Wang wrote: > Webrev updated again at > > https://cr.openjdk.java.net/~weijun/6722928/webrev.04/ > This time I updated gssapi.h to make use of gss_const_xyz_t types. The types > in NativeFunc.h and sspi.cpp are updated as well. (I wish there is a

Re: XML Digital Signature throws NAMESPACE_ERR exception under OpenJDK 11 that works under Java SE 8, 9 and 10

2019-02-15 Thread Sean Mullan
On 2/14/19 5:54 PM, Joe Wang wrote: his is the ASCII code for a carriage return, encoded in XML. I don't know why that behavior is different in JDK 11. This would be a question for the XML developers. I have copied Joe Wang, to see if he might know. Hi Sean, There hasn't been functional chan

Re: XML Digital Signature throws NAMESPACE_ERR exception under OpenJDK 11 that works under Java SE 8, 9 and 10

2019-02-15 Thread Sean Mullan
I know what the problem is. You also need to add the actual namespace attribute to your element, for example: qualifyingPropertiesElement.setAttributeNS(     "http://www.w3.org/2000/xmlns/";, "xmlns", "http://uri.etsi.org/01903/v1.1.1#";); You only need to do that on the top-most parent

Re: XML Digital Signature throws NAMESPACE_ERR exception under OpenJDK 11 that works under Java SE 8, 9 and 10

2019-02-15 Thread Open eSignForms
XML namespaces are pretty confusing.  From what little I gather, unprefixed attributes don't belong to any namespace, not even the default one. I think I can see the bug in the debugging output. On Java 8 and 10 and 11, I'd guess that the marshaling/canonicalization has issues when combining

[13] RFR JDK-8218780 "Update MUSCLE PCSC-Lite header files"

2019-02-15 Thread Valerie Peng
Hi Sean (Coffey), Can you please help reviewing this fix? It's about updating the PC/SC lite header files under the MUSCLE directory inside smartcardio module. The header files are from https://pcsclite.apdu.fr/ and minor adjustments are made to pcsc_md.h and pcsc.c to match the header update

Re: RFR 8180573: Refactor sun/security/tools shell tests to plain java tests

2019-02-15 Thread Weijun Wang
Hi Philipp, In most cases, it's just about creating a non-empty file; in some case, the content is relevant. For the former, I will change it to something like "new byte[10]"; for the latter, I'll use getBytes(UTF_8). Thanks, Max > On Feb 15, 2019, at 5:34 PM, Philipp Kunz wrote: > > Hi Max

Re: Java SSLSocketChannel/SSLSelector?

2019-02-15 Thread David Lloyd
Then your selector can only be used for SSL things. What if someone decides to take the exact same approach to solve some other higher-OSI-layer protocol decoding? Now you have to choose which kind of protocol you want your selector to support. Note that with a plain selector and plain sockets,

Re: RFR 8180573: Refactor sun/security/tools shell tests to plain java tests

2019-02-15 Thread Philipp Kunz
Hi Max, I don't know if it is important enough, certainly not a serious issue. In your patch, for example in DiffEnd.java and a few other tests, Strings are encoded to byte streams with String.getBytes() which uses the default platform character set to encode the strings. Manifests, however, alway

Re: Java SSLSocketChannel/SSLSelector?

2019-02-15 Thread Andi Mullaraj
Hi Dean, Thanks for sharing your experience. I took a look at your links and the model and implementation seems quite distant from the classic Selector/SelectableChannel though. You seem to allocate a thread per each Selector (which I agree is too much of a cost to pay), then fire actively [listen