RFR[13] JDK-8204203: Many pkcs11 tests failed in Provider initialization, after compiler on Windows changed

2019-04-23 Thread sha . jiang
Hi, NSS 3.41 has been approved, so just build this version for windows (with VS2017) and macosx. Webrev: http://cr.openjdk.java.net/~jjiang/8204203/webrev.00/ Issue: https://bugs.openjdk.java.net/browse/JDK-8204203 Best regards, John Jiang

Re: RFR 8222805: sun/security/pkcs11/tls/tls12/TestTLS12.java fails with Unsupported signature algorithm: rsa_pss_rsae_sha256

2019-04-23 Thread Martin Balao
Hi Sean, Xuelei, Thanks for your feedback. You're both right, the security property value was not being considered (and my testing environments are not helping at all, as I could not reproduce the bug). Here it's Webrev.01: * http://cr.openjdk.java.net/~mbalao/webrevs/8222805/8222805.webrev.01/

RFR: 8036608: Key.getAlgorithm link to standard algorithm names needs to be updated

2019-04-23 Thread Sean Mullan
Please review this javadoc only change to be more specific about the standard algorithm names that Key.getAlgorithm may return. The fix lists the specific sections of the Standard Algorithm Names specification that are relevant. webrev: http://cr.openjdk.java.net/~mullan/webrevs/8036608/webrev

Re: RFR 8222805: sun/security/pkcs11/tls/tls12/TestTLS12.java fails with Unsupported signature algorithm: rsa_pss_rsae_sha256

2019-04-23 Thread Sean Mullan
Hi Martin, On 4/23/19 3:26 PM, Martin Balao wrote: Hi, I'd like to propose a fix for 8222805 [1]. Webrev.00: * http://cr.openjdk.java.net/~mbalao/webrevs/8222805/8222805.webrev.00/ This issue is similar to 8221271 [2]: jdk.tls.disabledAlgorithms property is only read when SSLAlgorithmConst

Re: RFR 8222805: sun/security/pkcs11/tls/tls12/TestTLS12.java fails with Unsupported signature algorithm: rsa_pss_rsae_sha256

2019-04-23 Thread Xuelei Fan
I think "jdk.tls.disabledAlgorithms" is a Security Property, while "-Djdk.tls.disabledAlgorithms=..." is used to define System Property. I'm not sure if this update works. You could put the Security Property update code in the beginning of the main() method, or the initialize() method which is

RFR 8222805: sun/security/pkcs11/tls/tls12/TestTLS12.java fails with Unsupported signature algorithm: rsa_pss_rsae_sha256

2019-04-23 Thread Martin Balao
Hi, I'd like to propose a fix for 8222805 [1]. Webrev.00: * http://cr.openjdk.java.net/~mbalao/webrevs/8222805/8222805.webrev.00/ This issue is similar to 8221271 [2]: jdk.tls.disabledAlgorithms property is only read when SSLAlgorithmConstraints class is initialized and if this happens before