> On May 9, 2019, at 11:40 AM, Weijun Wang wrote:
>
> Wow, this is overwhelming. Please post updated webrevs here and we will push
> the final agreed version, one by one.
Also, all your comments and responses posted in the previous mail are on files
but not on a specific bug. Now that all bu
Wow, this is overwhelming. Please post updated webrevs here and we will push
the final agreed version, one by one.
IANAL, but I think the principal is that the content of all changes should be
from you -- the OCA signers. As long as there is only discussion and no actual
code contribution, talk
I've added comments to both and pushed it.
Thanks,
Max
> On May 9, 2019, at 12:24 AM, Sean Mullan wrote:
>
> I think it would be useful to add a comment in the test and/or in the bug
> report with a brief explanation as to why it is not run on Solaris.
> Otherwise, fix looks fine.
>
> --Sean
It looks good to me.
Xuelei
On 5/8/2019 7:58 AM, Weijun Wang wrote:
This test timed out on solaris-sparc multiple times while generating an
8192-bit RSA key pair. Since the test is used to ensure keytool's support for
the RSASSA-PSS algorithm (and the default signature algorithm depending on
I think it would be useful to add a comment in the test and/or in the
bug report with a brief explanation as to why it is not run on Solaris.
Otherwise, fix looks fine.
--Sean
On 5/8/19 10:58 AM, Weijun Wang wrote:
This test timed out on solaris-sparc multiple times while generating an
8192-
This test timed out on solaris-sparc multiple times while generating an
8192-bit RSA key pair. Since the test is used to ensure keytool's support for
the RSASSA-PSS algorithm (and the default signature algorithm depending on the
key size) it's not platform related. Therefore I suggest simply ign
Thank you! Yes, the change is good to me.
Regards,
Xuelei
On 5/8/2019 7:01 AM, Langer, Christoph wrote:
Hi Xuelei,
thanks for looking.
The warnings would appear in my Eclipse IDE. During the tests (build) nothing
had been observed and this will hopefully still be the same. 😊
So you are goo
Hi Xuelei,
thanks for looking.
The warnings would appear in my Eclipse IDE. During the tests (build) nothing
had been observed and this will hopefully still be the same. 😊
So you are good with the changes?
Best regards
Christoph
> -Original Message-
> From: Xuelei Fan
> Sent: Mittwoc
Hi Christoph,
Did you see compiler warning for the files? I tried with the JDK
repository build, no compiler warning message. The update is safe. I
may miss something about why we want to make the update.
Thanks,
Xuelei
On 5/8/2019 1:21 AM, Langer, Christoph wrote:
Hi,
please review thi
Hi,
please review this small change which contains a few minor cleanups to the
tests for the CA certificates. I had it in my mercurial queue for quite some
time and always wanted to contribute it 😊
Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8223555.0/
Bug: https://bugs.openjdk.java.net
10 matches
Mail list logo
