Re: [13] RFR JDK-7107615 "scalability bloker in javax.crypto.JceSecurity"

Hi Valerie, This looks good to me. I just wonder why IdentityWrapper has a parameter type as it seems it's only used with T = Provider. I mean - this is fine - and I understand why you did it this way as the general purpose parameterized class is much easier to name, but I wonder if you wouldn't

Re: [13] RFR JDK-7107615 "scalability bloker in javax.crypto.JceSecurity"

On 15/05/2019 20:11, Valerie Peng wrote: I updated the webrev to switch to ConcurrentHashMap. The javadoc spec of computeIfAbsent method cautioned that the mapping func should be short and simple and must not attempt to update other mappings of this map. Provider verification code does not quit

RFR: 8223499: Remove two DocuSign root certificates that are expiring

Please review this fix for removal of two DocuSign root CAcertificates. Webrev: http://cr.openjdk.java.net/~rhalade/8223499/webrev.00/ Release note is at - https://bugs.openjdk.java.net/browse/JDK-8224004 Thanks, Rajan

Re: RFR 8223482: Unsupported ciphersuites may be offered by a TLS client

Hi Xuelei, Thanks for your feedback. We can move the supported ciphersuites check to SSLContextImpl.getApplicableCipherSuites method and affect the default list of enabled ciphersuites only. This list is set in SSLContextImpl initialization time, so the performance is not impacted. On the other h

[8u] RFR: 8203190: SessionId.hashCode generates too many collisions

Hi, Could I please get a review of this OpenJDK 8u only fix? JDKs 11+ don't seems to have this issue as with the TLS 1.3 feature (JDK-8196584) SessionId.hashCode() got changed to use Arrays.hashCode() already. webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8203190/01/webrev/ Bug: https:

Re: [8u] RFR: 8203190: SessionId.hashCode generates too many collisions

On 16/05/2019 18:51, Severin Gehwolf wrote: > Hi, > > Could I please get a review of this OpenJDK 8u only fix? JDKs 11+ don't > seems to have this issue as with the TLS 1.3 feature (JDK-8196584) > SessionId.hashCode() got changed to use Arrays.hashCode() already. > > webrev: http://cr.openjdk.jav

Re: RFR: 8223499: Remove two DocuSign root certificates that are expiring

Looks good. --Sean On 5/16/19 12:29 PM, Rajan Halade wrote: Please review this fix for removal of two DocuSign root CAcertificates. Webrev: http://cr.openjdk.java.net/~rhalade/8223499/webrev.00/ Release note is at - https://bugs.openjdk.java.net/browse/JDK-8224004 Thanks, Rajan

RFR 8211018: Session Resumption without Server-Side State

I'm asking for a review of this rather large change to add support stateless tickets in the TLS 1.3 5077 RFC. https://bugs.openjdk.java.net/browse/JDK-8211018 http://cr.openjdk.java.net/~ascarpino/stateless/webrev.00 thanks Tony