RFR[13] JDK-8181386: CipherSpi ByteBuffer to byte array conversion fails for certain data overlap conditions

Anyone can help review this fix on ByteBuffer input/output encryption? The fix should be self-explanatory with the comments. Bug: https://bugs.openjdk.java.net/browse/JDK-8181386 Webrev:http://cr.openjdk.java.net/~valeriep/8181386/webrev.00/

Re: [8u] RFR: Backport 8208648: ECC Field Arithmetic Enhancements

Hi, Here is the proper RFR for 8208648: ECC Field Arithmetic Enhancements Sorry for the confusion Bug: https://bugs.openjdk.java.net/browse/JDK-8208648 Original: http://hg.openjdk.java.net/jdk/jdk/rev/746602d9682f Webrev: http://cr.openjdk.java.net/~phh/8208648/webrev.8u.00/ JDK-8208648 is mark

[8u] RFR: Backport 8208648: ECC Field Arithmetic Enhancements

Hi, Please review this backport of JDK-8181594: Efficient and constant-time modular arithmetic Bug: https://bugs.openjdk.java.net/browse/JDK-8181594 Original: http://hg.openjdk.java.net/jdk/jdk/rev/d213d70182a9 Webrev: http://cr.openjdk.java.net/~phh/8181594/webrev.8u.00/ JDK-8181594 is marked

Re: [8u] RFR: Backport 8181594: Efficient and constant-time modular arithmetic

Correction, this is the RFR for 8181594: Efficient and constant-time modular arithmetic On 2019-06-14, 14:13, "Alvarez, David" wrote: Hi, Please review this backport of JDK-8181594: Efficient and constant-time modular arithmetic Bug: https://bugs.openjdk.java.net/browse/

[8u] RFR Backport: 8208698: Improved ECC Implementation

Hi, Please review this backport of JDK-8208698: Improved ECC Implementation Bug: https://bugs.openjdk.java.net/browse/JDK-8208698 Original: http://hg.openjdk.java.net/jdk/jdk/rev/752e57845ad2 Webrev: http://cr.openjdk.java.net/~phh/8208698/webrev.8u.00/ JDK-8208698 is marked as jdk8u-critical-ye

Re: [13] RFR: JDK-8225392: Comparison builds are failing due to cacerts file

On 6/14/19 11:33 AM, Weijun Wang wrote: Here is the updated webrev http://cr.openjdk.java.net/~weijun/8225392/webrev.01/ The only change is ordering in 'keytool -list' and its test. Looks fine. --Sean Thanks, Max On Jun 14, 2019, at 7:55 PM, Sean Mullan wrote: On 6/14/19 1:49 AM, W

Re: [13] RFR: JDK-8225392: Comparison builds are failing due to cacerts file

I'm happy with this. /Erik On 2019-06-14 08:33, Weijun Wang wrote: Here is the updated webrev http://cr.openjdk.java.net/~weijun/8225392/webrev.01/ The only change is ordering in 'keytool -list' and its test. Thanks, Max On Jun 14, 2019, at 7:55 PM, Sean Mullan wrote: On 6/14/19 1:49

[13] RFR: JDK-8225392: Comparison builds are failing due to cacerts file

Here is the updated webrev http://cr.openjdk.java.net/~weijun/8225392/webrev.01/ The only change is ordering in 'keytool -list' and its test. Thanks, Max > On Jun 14, 2019, at 7:55 PM, Sean Mullan wrote: > > On 6/14/19 1:49 AM, Weijun Wang wrote: >> BTW, something not related but similar: D

Re: RFR: JDK-8225392: Comparison builds are failing due to cacerts file

On 6/14/19 1:49 AM, Weijun Wang wrote: BTW, something not related but similar: Do you like me to also sort aliases alphabetically in the output of "keytool -list"? Yes, I think that is useful. --Sean

Re: RFR (S) 8225695: 32-bit build failures after JDK-8080462 (Update SunPKCS11 provider with PKCS11 v2.40 support)

On 13/06/2019 22:36, Aleksey Shipilev wrote: : Thanks. Not sure about the rules for that code, need another review, probably? One Reviewer is okay, only the hotspot area require two for non-trivial changes. -Alan