Re: [14] RFR(M) 8185139: [Graal] Tests which set too restrictive security manager fail with Graal

2019-06-21 Thread Vladimir Kozlov
Thank you, Mandy On 6/20/19 6:20 PM, Mandy Chung wrote: Hi Vladimir, As long as the owner of the test review the patch and confirm the test policy intends to extend the default policy, those test change will be fine. test/jdk/java/lang/Class/getDeclaredField/FieldSetAccessibleTest.java 417 DE

Re: [8u] RFR: Backport 8181594: Efficient and constant-time modular arithmetic

2019-06-21 Thread Andrew John Hughes
On 18/06/2019 20:30, Alvarez, David wrote: > Here is the updated webrev with suggested changes: > > Bug: https://bugs.openjdk.java.net/browse/JDK-8181594 > Original: http://hg.openjdk.java.net/jdk/jdk/rev/d213d70182a9 > Webrev: http://cr.openjdk.java.net/~phh/8181594/webrev.8u.02/ > > -- > Davi

Re: [14] RFR(M) 8185139: [Graal] Tests which set too restrictive security manager fail with Graal

2019-06-21 Thread Daniel Fuchs
Hi Sean, On 21/06/2019 15:36, Sean Mullan wrote: Ok, I see that is challenging, and I understand why you had to do that. You probably could have done something similar by breaking up the test into multiple classes in separate directories (or jars) with different ProtectionDomains, but that wou

Re: [14] RFR(M) 8185139: [Graal] Tests which set too restrictive security manager fail with Graal

2019-06-21 Thread Sean Mullan
On 6/20/19 9:02 PM, Mandy Chung wrote: On 6/20/19 1:40 PM, Sean Mullan wrote: Sorry, I'm just catching up and looking at this now. The one thing I don't like about these tests that use their own Policy implementation is that the permissions that are granted inside the test are granted to all

Re: [14] RFR(M) 8185139: [Graal] Tests which set too restrictive security manager fail with Graal

2019-06-21 Thread Sean Mullan
On 6/21/19 7:15 AM, Daniel Fuchs wrote: Hi Sean, On 20/06/2019 21:40, Sean Mullan wrote:  This could also be fixed in these tests by inspecting the CodeSource of the ProtectionDomain. Or better yet, they should just use the jtreg java.security.policy option and a policy file and avoid the need

Re: [14] RFR(M) 8185139: [Graal] Tests which set too restrictive security manager fail with Graal

2019-06-21 Thread Daniel Fuchs
Hi Sean, On 20/06/2019 21:40, Sean Mullan wrote: This could also be fixed in these tests by inspecting the CodeSource of the ProtectionDomain. Or better yet, they should just use the jtreg java.security.policy option and a policy file and avoid the need to create a Policy implementation. In

Re: [13]RFR:8224650:Add tests to support X25519 and X448 in TLS

2019-06-21 Thread sha . jiang
Hi Siba, I have some minor comments. Now that JDK-8225766 has been fixed, I suppose this test can cover some ECDHE_ECDSA cipher suites.   48 private static volatile int index;   ...   56 for (String c : getCiphers(protocols[index], args[0])) {   ...   66 String[] ps = n

[13]RFR:8224650:Add tests to support X25519 and X448 in TLS

2019-06-21 Thread Sibabrata Sahoo
Hi Xuelei/Brad, Please review the patch for, JBS: https://bugs.openjdk.java.net/browse/JDK-8224650 Webrev: http://cr.openjdk.java.net/~ssahoo/8224650/webrev.00/ This is a small Test inherited from "SSLSocketTemplate" and reuse most part of it. The only difference is, it uses supported