Re: [13]RFR:8224650:Add tests to support X25519 and X448 in TLS

2019-06-27 Thread sha . jiang
Hi, Because Siba has to be offline for some days, now I take over this task. Please review this updated webrev: http://cr.openjdk.java.net/~jjiang/8224650/webrev.01/ It covers more cipher suites, and changes SSLSocketTemplate.java on creating SSL context. Now, SSLSocketTemplate.java contains ne

RE: [11u] RFR: 8208698: Improved ECC Implementation

2019-06-27 Thread Langer, Christoph
Dang, you're right! I'll open an issue and put it out for review. I guess you'll want to push it in your closed repository? BTW: I just reported another regression which affects 11.0.4 as well: https://bugs.openjdk.java.net/browse/JDK-8226876 It's "just" a Java level assert but maybe we'll ne

[11u] RFR (S): 8226880: Backport of JDK-8208698 (Improved ECC Implementation) should not bring parts of JDK-8205476 (KeyAgreement#generateSecret is not reset for ECDH based algorithm)

2019-06-27 Thread Langer, Christoph
Hi, I made a mistake when bringing JDK-8226880 to 11u. The patch introduced coding of JDK-8205476 that should not be there. Here is a patch to fix this. Bug: https://bugs.openjdk.java.net/browse/JDK-8226880 Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8226880.11u.0/ As the backport is in

Re: [13]RFR:8224650:Add tests to support X25519 and X448 in TLS

2019-06-27 Thread Xuelei Fan
Looks good to me. Xuelei On 6/27/2019 1:05 AM, sha.ji...@oracle.com wrote: Hi, Because Siba has to be offline for some days, now I take over this task. Please review this updated webrev: http://cr.openjdk.java.net/~jjiang/8224650/webrev.01/ It covers more cipher suites, and changes SSLSocketT

Re: Is Digicert's continued use of the "Distrusted" certificates for code signing still valid?

2019-06-27 Thread Sean Mullan
Hi Bert, Thanks for your post. We will be looking into it further and hope to have a more detailed response in a few weeks. Thanks, Sean On 6/25/19 2:08 PM, Bert Eisen wrote: Hello, I’m trying to understand why Digicert are still issuing signing certificates from the distrusted Symantec ro

Re: [11u] RFR (S): 8226880: Backport of JDK-8208698 (Improved ECC Implementation) should not bring parts of JDK-8205476 (KeyAgreement#generateSecret is not reset for ECDH based algorithm)

2019-06-27 Thread Andrew John Hughes
On 27/06/2019 11:12, Langer, Christoph wrote: > Hi, > >   > > I made a mistake when bringing JDK-8226880 to 11u. The patch introduced > coding of JDK-8205476 that should not be there. Here is a patch to fix this. > >   > > Bug: https://bugs.openjdk.java.net/browse/JDK-8226880 > > Webrev: htt

[13] RFR JDK-8226651: Setting the mgfHash in CK_RSA_PKCS_PSS_PARAMS has no effect

2019-06-27 Thread Valerie Peng
Hi, Anyone has time to review this? Trivial and straightforward and would be nice to fix this in the same release which the bug is introduced in. Existing PKCS11 PSS impl assumes that the MGF1 uses the same digest algorithm as the message digest. Fixed to get the digest algorithm for MGF1 fro

Re: [13] RFR JDK-8226651: Setting the mgfHash in CK_RSA_PKCS_PSS_PARAMS has no effect

2019-06-27 Thread Xuelei Fan
The update looks good to me. Does the SunRsaSign provider (RSAPSSSignature.java) has a similar problem? Thanks, Xuelei On 6/27/2019 3:24 PM, Valerie Peng wrote: Hi, Anyone has time to review this? Trivial and straightforward and would be nice to fix this in the same release which the bug is

Re: [13] RFR JDK-8226651: Setting the mgfHash in CK_RSA_PKCS_PSS_PARAMS has no effect

2019-06-27 Thread Valerie Peng
No, this problem only applies to SunPKCS11 provider. SunRsaSign provider is fine. Thanks for the review, Valerie On 6/27/2019 4:15 PM, Xuelei Fan wrote: The update looks good to me. Does the SunRsaSign provider (RSAPSSSignature.java) has a similar problem? Thanks, Xuelei On 6/27/2019 3:24

Re: [8u] RFR Backport: 8208698: Improved ECC Implementation

2019-06-27 Thread Andrew John Hughes
On 14/06/2019 23:33, Alvarez, David wrote: > Hi, > > Please review this backport of JDK-8208698: Improved ECC Implementation > > Bug: https://bugs.openjdk.java.net/browse/JDK-8208698 > Original: http://hg.openjdk.java.net/jdk/jdk/rev/752e57845ad2 > Webrev: http://cr.openjdk.java.net/~phh/820869

Re: [8u] RFR Backport: 8208698: Improved ECC Implementation

2019-06-27 Thread Alvarez, David
Looks good to me > On 27 Jun 2019, at 19:53, Andrew John Hughes wrote: > > > >> On 14/06/2019 23:33, Alvarez, David wrote: >> Hi, >> >> Please review this backport of JDK-8208698: Improved ECC Implementation >> >> Bug: https://bugs.openjdk.java.net/browse/JDK-8208698 >> Original: http://hg.o