RE: [11u]: RFR: Backport of 8215694: keytool cannot generate RSASSA-PSS certificates

2019-06-28 Thread Langer, Christoph
Hi again, I had to make some additions to get the test sun/security/tools/keytool/PSS.java to work. Firstly, I had to include the testlibrary utility class 'test/lib/jdk/test/lib/security/DerUtils.java' from the change for JDK-8076190. Then I had to add some code to src/java.base/share/classe

Re: RFR 8217375: jarsigner breaks old signature with long lines in manifest

2019-06-28 Thread sha . jiang
Hi, Sorry for this late reply! I only focus on the changes on the tests in sun/security/tools/jarsigner/compatibility. Compatibility.java has been modified significantly, I just had a quick look at it. sun/security/tools/jarsigner/compatibility/SignTwice.java With my test

RFR [13] JDK-8226374 Restric signature algorithms and named groups

2019-06-28 Thread Xuelei Fan
Hi, Could I get the following update reviewed? http://cr.openjdk.java.net/~xuelei/8226374/webrev.00/ During handshaking, the selection of signature algorithms was not checked with the algorithm constraints. Then the available signature algorithms may be ignored if a restricted algorithm g

Re: [8u] RFR Backport: 8208698: Improved ECC Implementation

2019-06-28 Thread Andrew John Hughes
On 28/06/2019 07:14, Alvarez, David wrote: > Looks good to me > Thanks David. Pushed: https://hg.openjdk.java.net/jdk8u/jdk8u/jdk/rev/9b5707865a97 -- Andrew :) Senior Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net

[13] RFR 8226963: More clarification on possible sequencing error in GSSContext::unwrap

2019-06-28 Thread Weijun Wang
Please take a review at http://cr.openjdk.java.net/~weijun/8226963/webrev.00/ Looks like some users are not aware of the MessageProp parameter in unwrap and forget to check about it. This fix adds some code in the example of the GSSContext class spec. Thanks, Max