JDK 14 RFR of JDK-8229999 : Apply java.io.Serial annotations to security types in java.base

2019-08-27 Thread Joe Darcy
Hello, Recent work for JDK-8202385: "Annotation to mark serial-related fields and methods" added the java.io.Serial annotation type to the platform. The intention of this new annotation type is to allow serialization-related fields and methods to be marked as documentation and to allow strict

Re: Slow LoginContext.login() due to repeated ServiceLoader lookups

2019-08-27 Thread Florent Guillaume
I'm not an Author so I created the ticket on bugreport.java.com, it has the internal review ID 9062061 Thanks, Florent On Tue, Aug 27, 2019 at 6:04 PM Seán Coffey wrote: > Probably best to log a bug to capture this issue. > > It reminds me of another issue I've been meaning to wrap up: > https:

Re: Slow LoginContext.login() due to repeated ServiceLoader lookups

2019-08-27 Thread Seán Coffey
Probably best to log a bug to capture this issue. It reminds me of another issue I've been meaning to wrap up: https://bugs.openjdk.java.net/browse/JDK-8223260 Similar scenario in how the ContextFactory is searched for. My proposed patch is to cache a factory per classloader (for the NamingManag

Slow LoginContext.login() due to repeated ServiceLoader lookups

2019-08-27 Thread Florent Guillaume
Hi, When switching from Java 8 to Java 11, we're experiencing an important slowdown when executing LoginContext.login(), especially under concurrency. We tracked this down to JDK-8047789 which changed the way the lookup of LoginModules is done in LoginContext.invoke. Previously, it was a simple C

Re: [14] RFR 8162628: Migrate cacerts keystore from JKS

2019-08-27 Thread Weijun Wang
Oops, sorry. I was calling "new X509CertImp" in PEM keystore and this has not made use of the cache in X509Factory, and since my benchmark test loads keystores hundreds of times it's certainly much slower than JKS. I've disabled the cache and now PEM is only around 20% slower than JKS. I'm sure