Re: [8u] RFR: 8226607: Inconsistent info between pcsclite.md and MUSCLE headers

2019-09-02 Thread Severin Gehwolf
On Mon, 2019-09-02 at 15:38 +0100, Andrew John Hughes wrote: > > On 26/08/2019 14:24, Severin Gehwolf wrote: > > Hi, > > > > Could I get a review of this follow-up fix for an 8u backport (JDK- > > 8218780)? This follow-up re-adds a COPYING file to the MUSCLE pcsc > > library header files removed

Re: [8u] RFR: 8226607: Inconsistent info between pcsclite.md and MUSCLE headers

2019-09-02 Thread Andrew John Hughes
On 26/08/2019 14:24, Severin Gehwolf wrote: > Hi, > > Could I get a review of this follow-up fix for an 8u backport (JDK- > 8218780)? This follow-up re-adds a COPYING file to the MUSCLE pcsc > library header files removed by the JDK-8218780 backport. The patch > differs from the version in JDK 1

Re: [8u] RFR: 8218780: Update MUSCLE PCSC-Lite header files

2019-09-02 Thread Andrew John Hughes
On 02/09/2019 13:14, Severin Gehwolf wrote: snip... >>> >> >> Most of this looks good. I was a little confused at first because the >> patch in your webrev looks quite different to the 11u changeset. >> However, once applied locally to the 8u repo, the diff between the two >> was as suggested a

[testsabilization] RFR: 8230435: Replace wildcard address with loopback or local host in tests - part 22

2019-09-02 Thread Daniel Fuchs
Hi, (cc-ing security dev for the changes in test/jdk/javax/net/ssl/templates/SSLSocketTemplate.java which is updated to allow for binding on a specific IP Address) Please find below a patch for: 8230435: Replace wildcard address with loopback or local host in tests - part 22 https://

Re: [8u] RFR: 8218780: Update MUSCLE PCSC-Lite header files

2019-09-02 Thread Severin Gehwolf
Hi Andrew, Thanks for the review! On Wed, 2019-08-28 at 18:15 +0100, Andrew John Hughes wrote: > On 26/08/2019 14:23, Severin Gehwolf wrote: > > Hi, > > > > Could I please get a review of this MUSCLE header files update in > > OpenJDK 8u? I'd like to backport this bug as it's also going to be in