On 9/26/19 4:20 PM, Sean Mullan wrote:
Would you prefer I revise the patch where there are multiple
SuppressWarnings("serial") on fields to put a single one on the class
instead?
Yes, but only in the cases where we are clearly using some form of
alternate serialization like ASN.1 encoding. I
On 9/26/19 4:10 PM, Joe Darcy wrote:
Hi Sean,
On 9/26/2019 12:46 PM, Sean Mullan wrote:
On 9/23/19 4:16 PM, Joe Darcy wrote:
Hi Sean,
On 9/23/2019 12:19 PM, Sean Mullan wrote:
Hi Joe,
It's a little odd to suppress the warnings in the X509CertImpl class
since it is a subclass of java.securi
Hi Sean,
On 9/26/2019 12:46 PM, Sean Mullan wrote:
On 9/23/19 4:16 PM, Joe Darcy wrote:
Hi Sean,
On 9/23/2019 12:19 PM, Sean Mullan wrote:
Hi Joe,
It's a little odd to suppress the warnings in the X509CertImpl class
since it is a subclass of java.security.cert.Certificate which
implements
On 9/26/19 3:41 PM, Roger Riggs wrote:
Sean,
I think that's the other EncryptionKey.
The one in
src/java.security.jgss/share/classes/sun/security/krb5/EncryptionKey.java isn't.
Right you are! Ok, never mind about my comment.
--Sean
Roger
On 9/26/19 3:35 PM, Sean Mullan wrote:
- Krb5C
On 9/23/19 4:16 PM, Joe Darcy wrote:
Hi Sean,
On 9/23/2019 12:19 PM, Sean Mullan wrote:
Hi Joe,
It's a little odd to suppress the warnings in the X509CertImpl class
since it is a subclass of java.security.cert.Certificate which
implements the writeReplace method so these fields are not seria
Sean,
I think that's the other EncryptionKey.
The one in
src/java.security.jgss/share/classes/sun/security/krb5/EncryptionKey.java
isn't.
Roger
On 9/26/19 3:35 PM, Sean Mullan wrote:
- Krb5Context.java
1394 @SuppressWarnings("serial") // Not statically typed as
Serializable
1395
- Krb5Context.java
1394 @SuppressWarnings("serial") // Not statically typed as
Serializable
1395 private final EncryptionKey key;
EncryptionKey is Serializable (it derives from java.security.Key which
is Serializable). I was wondering why we needed to suppress the warning
her
Hi Christoph, you are right - I should better use getVersionStr() , I’ll
replace it .
Valerie are you fine with the latest webrev ?
Best regards, Matthias
From: Langer, Christoph
Sent: Mittwoch, 25. September 2019 16:50
To: Baesken, Matthias ; Valerie Peng
; security-dev@openjdk.java.
