Hi Sean,
Getting back to this review...
On 9/26/2019 1:55 PM, Sean Mullan wrote:
On 9/26/19 4:20 PM, Sean Mullan wrote:
Would you prefer I revise the patch where there are multiple
SuppressWarnings("serial") on fields to put a single one on the
class instead?
Yes, but only in the cases wher
Hi Sean,
Amended as requested before pushing; thanks,
-Joe
On 10/8/2019 2:12 PM, Sean Mullan wrote:
I would change "asn1" to "ASN.1" in the comment as that is the more
common usage of the acronym, otherwise looks good.
Thanks,
Sean
On 10/8/19 1:36 PM, Joe Darcy wrote:
PS And a revised webre
I would change "asn1" to "ASN.1" in the comment as that is the more
common usage of the acronym, otherwise looks good.
Thanks,
Sean
On 10/8/19 1:36 PM, Joe Darcy wrote:
PS And a revised webrev acting on comments from the JDK-8231262 to use a
single class-level @SuppressWarnings when an alterna
PS And a revised webrev acting on comments from the JDK-8231262 to use a
single class-level @SuppressWarnings when an alternative serial form is
implicitly being used:
http://cr.openjdk.java.net/~darcy/8231368.1/
Thanks,
-Joe
On 10/8/2019 10:11 AM, Joe Darcy wrote:
Hi Sean,
Returning t
Hi Sean,
Returning to this review
On 9/26/2019 12:35 PM, Sean Mullan wrote:
- Krb5Context.java
1394 @SuppressWarnings("serial") // Not statically typed as
Serializable
1395 private final EncryptionKey key;
EncryptionKey is Serializable (it derives from java.security.Key
