RFR 8228969: 2019-10 public suffix list update

2019-10-09 Thread Weijun Wang
http://cr.openjdk.java.net/~weijun/8228969/webrev.00/ Thanks, Max

Re: [JDK-8223172] Incomplete/Unusable Kerberos Cross-Realm Referrals Support

2019-10-09 Thread Weijun Wang
Hi Michael, Thanks for trying this new feature, you are always the first one. If I remember correctly, when Martin developed this new feature, he was thinking of adding as little as possible spec change at the beginning. Therefore although there is a new KerberosPrincipal::KRB_NT_ENTERPRISE co

RE: RFR: 8231887: ComodoCA.java fails because certificate was revoked

2019-10-09 Thread Langer, Christoph
+1 Thanks, Christoph > -Original Message- > From: Sean Mullan > Sent: Mittwoch, 9. Oktober 2019 20:58 > To: Rajan Halade ; security- > d...@openjdk.java.net > Cc: Langer, Christoph > Subject: Re: RFR: 8231887: ComodoCA.java fails because certificate was > revoked > > You should add the

Re: RFR: 8231887: ComodoCA.java fails because certificate was revoked

2019-10-09 Thread Sean Mullan
You should add the bugid to @bug and it probably should have a noreg-self label. Looks good otherwise. --Sean On 10/9/19 1:56 PM, Rajan Halade wrote: Please review this fix in ComodoCA.java test to update test certificates used. CA revoked earlier test artifacts so we need to update those. W

RFR: 8231887: ComodoCA.java fails because certificate was revoked

2019-10-09 Thread Rajan Halade
Please review this fix in ComodoCA.java test to update test certificates used. CA revoked earlier test artifacts so we need to update those. Webrev: http://cr.openjdk.java.net/~rhalade/8231887/webrev.00/ Thanks, Rajan

Re: JDK 14 RFR of JDK-8231262: Suppress warnings on non-serializable instance fields in security libs serializable classes

2019-10-09 Thread Joe Darcy
Hi Chris and Sean, I'll push a fix for JDK-8231262 with a single class-level suppression in X509CertImpl:     @SuppressWarnings("serial") // See writeReplace method in Certificate I've filed         JDK-8232062: Clarify serialization mechanisms of X509CertImpl for the follow-up work. Thank

Re: JDK 14 RFR of JDK-8231262: Suppress warnings on non-serializable instance fields in security libs serializable classes

2019-10-09 Thread Chris Hegarty
On 09/10/2019 14:54, Sean Mullan wrote: ... X509CertImpl extends X509Certificate which extends Certificate. Certificate has a writeReplace method. Another possible follow-on is to add readObject methods, that unconditionally throw, to both X509Certificate and X509CertImpl, since serializ

Re: JDK 14 RFR of JDK-8231262: Suppress warnings on non-serializable instance fields in security libs serializable classes

2019-10-09 Thread Sean Mullan
On 10/8/19 9:56 PM, Joe Darcy wrote: Hi Sean, Getting back to this review... On 9/26/2019 1:55 PM, Sean Mullan wrote: On 9/26/19 4:20 PM, Sean Mullan wrote: Would you prefer I revise the patch where there are multiple SuppressWarnings("serial") on fields to put a single one on the class inst