Re: [RFR] 8233404: System property to set the number of PBE iterations in JCEKS keystores

2019-11-07 Thread Weijun Wang
Hi Martin, Now that this is a system/security property, I suggest clarifying this in java.security. You can see similar words for other such properties like If the system property x.y.z is also specified, it supersedes the security property value defined here. Code change looks fine. I'll

Re: CSR review request JDK-8233621, Mismatch in jsse.enableMFLNExtension property name

2019-11-07 Thread Xuelei Fan
If there are two properties used for the same function, we need to respect one and discard another one. Which one should be respected? As could be confused. For example, property "pro-A" is set to "value-A", and property "pro-B" is set to "value-B", which value should be used? If "pro-A" is

Re: RFR [14] 8214483: Remove algorithms that use MD5, DES, or ECB from security requirements

2019-11-07 Thread Mike StJohns
You deleted DES but not DESede. Was that intentional? Sent from my iPad > On Nov 7, 2019, at 17:12, Sean Mullan wrote: > > Ok, I have put back the Cipher algorithms with ECB mode that I had > previously removed (except for DES/ECB which is still removed). > > Updated webrev: https://cr.ope

CSR Review request (11-pool): JDK-8233825: Update SunPKCS11 provider with PKCS11 v2.40 support

2019-11-07 Thread Langer, Christoph
Hi Valerie, Sean, may I please ask you to add yourself as reviewer to the backport CSR JDK-8233825: "Update SunPKCS11 provider with PKCS11 v2.40 support" [0]. It is a CSR for backporting JDK-8080462 to OpenJKD 11u. Oracle did that already for 11.0.6 but with the internal ccc process. Joe indica

Re: RFR [14] 8214483: Remove algorithms that use MD5, DES, or ECB from security requirements

2019-11-07 Thread Sean Mullan
Ok, I have put back the Cipher algorithms with ECB mode that I had previously removed (except for DES/ECB which is still removed). Updated webrev: https://cr.openjdk.java.net/~mullan/webrevs/8214483/webrev.01/ --Sean On 11/6/19 5:43 PM, Michael StJohns wrote: On 11/6/2019 11:27 AM, Sean Mul

Re: CSR review request JDK-8233621, Mismatch in jsse.enableMFLNExtension property name

2019-11-07 Thread Sean Mullan
On 11/7/19 12:34 PM, Xuelei Fan wrote: As the property has a default value, so there is a problem to use two properties for the same purpose.  We don't really know if an application uses the misspelled name, or intended to use the default value. But you know if an application has set the prope

Re: CSR review request JDK-8233621, Mismatch in jsse.enableMFLNExtension property name

2019-11-07 Thread Xuelei Fan
As the property has a default value, so there is a problem to use two properties for the same purpose. We don't really know if an application uses the misspelled name, or intended to use the default value. For the current applications, if the implementation name get used, okay, they get the e

Re: [RFR] 8233404: System property to set the number of PBE iterations in JCEKS keystores

2019-11-07 Thread Martin Balao
Hi, I'd like to propose Webrev.01 for 8233404 [1]: * http://cr.openjdk.java.net/~mbalao/webrevs/8233404/8233404.webrev.01/ New in Webrev.01: * "jdk.jceks.iterationCount" is now a Security property too * documented in java.security file * IterationCount test re-written to cover "jdk.jceks.

Re: CSR review request JDK-8233621, Mismatch in jsse.enableMFLNExtension property name

2019-11-07 Thread Sean Mullan
I guess another option is to not change the name that is used in the docs, but change the code to look for both properties, trying the docs name first, and then the misspelled name. Not great, but probably the safest and least disruptive option. --Sean On 11/5/19 8:07 PM, Xuelei Fan wrote: I