Re: RFR 8234697: Generate sun.security.util.math.intpoly classes during build

2019-11-25 Thread Weijun Wang
> On Nov 26, 2019, at 12:36 AM, Erik Joelsson wrote: > > Build change looks good. Thanks. One question: I see the output to stdout from FieldGen.java shown in build. Is it possible to hide it but still store the output in the log file? I copied everything from CLDR_GEN_DONE but that one do

Re: [14] RFR JDK-8233016: javax.crypto.Cipher throws NPE for the given custom CipherSpi and Provider

2019-11-25 Thread Valerie Peng
Hi Sean, Thanks, I have changed the bug synopsis as well as CSR title and content accordingly. Please find more comments inline... On 11/25/2019 11:52 AM, Sean Mullan wrote: I would change the Bug summary to describe what is being proposed. Since two new exceptions are being specified in the

Re: [14] RFR JDK-8233016: javax.crypto.Cipher throws NPE for the given custom CipherSpi and Provider

2019-11-25 Thread Sean Mullan
I would change the Bug summary to describe what is being proposed. Since two new exceptions are being specified in the constructor, I would suggest: "Specify the exceptions that can be thrown by the javax.crypto.Cipher constructor". > CSR: https://bugs.openjdk.java.net/browse/JDK-8234271 I wo

Re: RFR 8234697: Generate sun.security.util.math.intpoly classes during build

2019-11-25 Thread Erik Joelsson
Build change looks good. /Erik On 2019-11-22 18:59, Weijun Wang wrote: Please review the change at http://cr.openjdk.java.net/~weijun/8234697/webrev.00/ The new lines in Gensrc-java.base.gmk mimics the one for CLDR_GEN_DONE at the beginning of the same file. I changed the BigInteger par