Ping the security side.
> On Nov 26, 2019, at 12:36 AM, Erik Joelsson wrote:
>
> Build change looks good.
>
> /Erik
>
> On 2019-11-22 18:59, Weijun Wang wrote:
>> Please review the change at
>>
>>http://cr.openjdk.java.net/~weijun/8234697/webrev.00/
>>
>> The new lines in
Thanks!
> On Dec 5, 2019, at 2:32 AM, Xuelei Fan wrote:
>
> Looks fine to me.
>
> Thanks,
> Xuelei
>
> On 12/2/2019 11:15 PM, Weijun Wang wrote:
>> Ping again.
>>> On Nov 16, 2019, at 10:02 PM, Weijun Wang wrote:
>>>
>>> Please take a review at
>>>
>>>
In line 601, doesn't this mean that SSL3/SSL20Hello are not longer
available as supported, and that you can't turn them back on?
Brad
On 12/4/2019 1:19 PM, Rajan Halade wrote:
May I request you to review following fix which removes SSLv2Hello and
SSLv3 from default enabled protocols.
SSLv3
May I request you to review following fix which removes SSLv2Hello and SSLv3
from default enabled protocols.
SSLv3 has been deprecated with RFC 7568. We have already disabled it by default
in 2015 by adding it to the jdk.tls.disabledAlgorithms property. This fix
removes it from default
Looks fine to me.
Thanks,
Xuelei
On 12/2/2019 11:15 PM, Weijun Wang wrote:
Ping again.
On Nov 16, 2019, at 10:02 PM, Weijun Wang wrote:
Please take a review at
http://cr.openjdk.java.net/~weijun/8234267/webrev.00/
Here, the returnDelims argument of the StringTokenizer is true so that
Hi Martin,
this makes sense. This is the right way to force alignment. I do not like
the platform code in the shared file but do not think this is a big deal.
+#if defined (_WIN32) && defined (_MSC_VER)
Why do you think we need _MSC_VER too? Is OpenJDK on Windows even buildable
with anything
Hi Martin,
thanks for looking into this and coming up with this patch. The test failures
were quite annoying
In hotspot, there is coding to define a macro "ATTRIBUTE_ALIGNED(x)". I'd
rather like to see that we define such a macro in the JDK code as well and use
it. I think it would make the
Also,
which JDK distro version of 8 are you using ? Note that the OpenJDK
version has an extra few pkcs11 fixes in OpenJDK in this area (compared
to the Oracle JDK 8 Updates) - Below being some of those :
https://bugs.openjdk.java.net/browse/JDK-8216597
