Looks good, and I see you have also drafted a CSR for this:
https://bugs.openjdk.java.net/browse/JDK-8235350
This looks good so I added my name as Reviewer. My only comment is that
you could be more specific about the fully-qualified names of the APIs
(instead of just getEnabledProtocols) and
The method at line 596 is only called at line 855 from customizedProtocols
class. It should really be read as getServerDefaultProtocols. Supported
protocols are returned correctly on SSLEngine, SSLServerSocket, and SSLSocket.
I thought about cleaning/renaming it but then AbstractTLSContext
Hi Thomas and Christoph,
thanks for the reviews.
Other code in java.security.jgss also uses these #defined checks:
src/java.security.jgss/share/native/libj2gss/gssapi.h:#if defined (_WIN32) &&
defined (_MSC_VER)
I’d like to have it consistent with that.
@Christoph: I think having
I reproduced the issue using AdoptOpenJDK 8_232 on Windows 10.
One of our customers faced the same problem on CentOS 7.6. I guess it is the
regular CentOS distribution.
Our first analysis of pkcs11 changes has been done on the following file :
Hello,
Thank you for the quick response.
The HSM we are using is the Bull Proteccio Trustway.
This is the pkcs11 config file :
name = Proteccio_PKCS11
library = /opt/bull/client/nethsm.so
slot = 1
attributes = compatibility
Thanks,
Hubert
-Original Message-
From: Valerie Peng
Hi Martin,
I can see that both places already include headers from
src/java.base/share/native/libjava/. I suggest adding the define in jni_util.h.
WindowsPreferences.c already includes it.
Best regards
Christoph
From: Doerr, Martin
Sent: Donnerstag, 5. Dezember 2019 12:00
To: Thomas Stüfe ;
