Re: RFR 8236470: Deal with ECDSA using ecdsa-with-SHA2 plus hash algorithm as AlgorithmId

2019-12-23 Thread Weijun Wang
> On Dec 24, 2019, at 12:11 AM, Xuelei Fan wrote: > > Will the update for getEncodedParams() has other compatibility impact? As it > is a public method, I'm not sure if the update is necessary and will impact > ECDSA encoding in other places. Please double check it. With the current code,

RE: [11u] RFR: 8213010: Supporting keys created with certmgr.exe

2019-12-23 Thread Lindenmaier, Goetz
Hi Christoph, Thanks for reviewing! Best regards, Goetz. > -Original Message- > From: Langer, Christoph > Sent: Monday, December 23, 2019 5:42 PM > To: Lindenmaier, Goetz ; jdk-updates- > d...@openjdk.java.net; OpenJDK Dev list > Subject: RE: [11u] RFR: 8213010: Supporting keys

RE: [11u] RFR: 8213010: Supporting keys created with certmgr.exe

2019-12-23 Thread Langer, Christoph
Hi Goetz, this looks good to me. I compared security.cpp after I've applied your changes to the version in jdk/jdk and there are only the changes missing that come with newer changes JDK-8223003 and JDK-8223063. Thanks for backporting this. Cheers Christoph > -Original Message- >

Re: RFR 8236470: Deal with ECDSA using ecdsa-with-SHA2 plus hash algorithm as AlgorithmId

2019-12-23 Thread Xuelei Fan
Will the update for getEncodedParams() has other compatibility impact? As it is a public method, I'm not sure if the update is necessary and will impact ECDSA encoding in other places. Please double check it. Otherwise, looks good to me. Xuelei On 12/21/2019 5:33 AM, Weijun Wang wrote: I