Re: 8237219: Disabling the native SunEC implementation

When the native impl is disabled, and an unsupported curve is used in key pair generation, ECDSA, or ECDH, when will the exception be thrown? Is it at the same place when native impl is enabled? I mean, do we need some sort of java isSupported()? SecurityTools.java: If native is disabled, will

RFR 8239928: ec/ECDSAJavaVerify.java failed due to timeout

Please take a review at https://cr.openjdk.java.net/~weijun/8239928/webrev.01/ Looks like on windows-x64 there is a small probability (~.1%) that VMDisconnectEvent will not be caught (and thus no VMDisconnectedException). Fortunately, in the 2 failure cases I observed, the VMDeathEvent is st

8237219: Disabling the native SunEC implementation

Hi I need a review of the CSR and webrev for disabling by default the native SunEC curves from the API. With the recent verification changes in JDK-8237218, SunJCE is long dependent on the native code for verifying the constant-time curves. This disabling can be undone with setting a syste

Re: RFR JDK-8233619: SSLEngine handshake status immediately after the handshake can be NOT_HANDSHAKING rather than FINISHED with TLSv1.3

ping ... On 2/22/2020 11:20 AM, Xuelei Fan wrote: Hi, Could I have the following update reviewed?     http://cr.openjdk.java.net/~xuelei/8233619/webrev.01/ For TLS 1.2 and previous versions, the ChangeCipherSpec message is always delivered before the Finished handshake message. ChangeCipherS

Re: RFR 8238555: Allow Initialization of SunPKCS11 with NSS when there are external FIPS modules in the NSSDB

On 2/27/20 9:48 PM, Valerie Peng wrote: Hi Martin, I have looked over the release note subtask and made some minor changes on wordings and added RN-Change label. Sean may have additional comments to add though. Also, when you mark it as delivered, the tech writer will also make their edit. J

Re: OpenJDK11u: Backward incompatible behavior

Hello Xuelei, Could you please review new version of the patch : http://cr.openjdk.java.net/~bae/8239788/webrev.v4/ I did not find any reasons for such getSession() behaviour. This code seems exists since initial TLSv1.2 implementation. As yo

Re: RFR 8240261: Use make/templates/gpl-cp-header in FieldGen.java

Build changes look ok. /Erik On 2020-02-29 05:02, Weijun Wang wrote: Please take a review at https://cr.openjdk.java.net/~weijun/8240261/webrev.00 Thanks, Max