Re: RFR [15] 8241014: Miscellaneous typos in documentation comments

Thanks Ivan, I merged your changes with mine and pushed the resulting changeset. > On 20 Mar 2020, at 20:11, Ivan Gerasimov wrote: > > Thank you Paul! > > grep found a few more occurrences of 'equals to' across java.base, so I > fixed them as well. > > Here's the updated webrev: > > http:/

Re: RFR [15] 8241014: Miscellaneous typos in documentation comments

Thank you Paul! grep found a few more occurrences of  'equals to'  across java.base, so I fixed them as well. Here's the updated webrev: http://cr.openjdk.java.net/~igerasim/XXX-typos/01/webrev/ Pavel, I checked your portion of correction, everything looks good to me! One minor nit:  I

Re: [15] RFR 8172680: Support SHA-3 based Hmac algorithms

Sure, I will do that. Thanks for the review~ Valerie On 3/19/2020 11:08 PM, Jamil Nimeh wrote: The CSR looks straightforward to me.  You might mention that these algorithms are Standard Names in the specification section, but it's just a nit. --Jamil On 3/19/2020 3:50 PM, Valerie Peng wrote:

Re: [15] RFR 8172680: Support SHA-3 based Hmac algorithms

Hi Max, I didn't touch AlgorithmId.java class in this RFE as these provider-defined HmacSHA3-xxx oids alias mapping are picked up by AlgorithmId.java inside its computeOidTable() method. AlgorithmId class should be still be able to find the String->oid string mapping from its oidTable field.

Re: security/infra/java/security/cert/CertPathValidator/certification/GlobalSignR6CA.java jtreg test errors

On 3/20/20 1:15 PM, Sean Mullan wrote: See also the March 20 issue at https://www.globalsign.com/en/status. I meant to say the March *2020* issue, where it says "Load-based issues in Singapore Data Centre", Updated on 18 March 2020. --Sean It could be related. I would monitor it going forw

Re: RFR [15] 8241014: Miscellaneous typos in documentation comments

+1 Paul. > On Mar 13, 2020, at 8:42 AM, Pavel Rappo wrote: > > Hello, > > Please review the change for https://bugs.openjdk.java.net/browse/JDK-8241014: > > http://cr.openjdk.java.net/~prappo/8241014/webrev.00/ > > This is a documentation cleanup. There are no code changes involved, > and t

Re: RFR [15] 8241014: Miscellaneous typos in documentation comments

--- a/src/java.base/share/classes/java/lang/invoke/MethodType.java +++ b/src/java.base/share/classes/java/lang/invoke/MethodType.java @@ -1379,12 +1379,12 @@ /** * This implementation returns {@code true} if {@code obj} is another - * {@code WeakEntry} whos

Re: security/infra/java/security/cert/CertPathValidator/certification/GlobalSignR6CA.java jtreg test errors

See also the March 20 issue at https://www.globalsign.com/en/status. It could be related. I would monitor it going forward and see if you have any more issues, and if so we can report it to GlobalSign. --Sean On 3/20/20 12:45 PM, Rajan Halade wrote: Hi Matthias, I tried several runs of this

Re: security/infra/java/security/cert/CertPathValidator/certification/GlobalSignR6CA.java jtreg test errors

Hi Matthias, I tried several runs of this test but am not able to reproduce the issue. May be requests from my tests are routed to different OCSP instance. OCSP responder instance can return internalError for inconsistent internal state. How frequent is the failure for you if you are still seei

Re: 8237219: Disabling the native SunEC implementation

On 3/19/20 5:46 PM, Anthony Scarpino wrote: On 3/19/20 12:23 PM, Sean Mullan wrote: On 3/12/20 2:23 AM, Anthony Scarpino wrote: Another webrev update with Max's recent comments. https://cr.openjdk.java.net/~ascarpino/8237219/webrev.03 Also I still need a reviewer for the CSR. For the CSR, I