Re: [15] RFR 8172680: Support SHA-3 based Hmac algorithms

2020-04-03 Thread Michael StJohns
Hi Valerie - In line On 4/3/2020 5:32 PM, Valerie Peng wrote: Hi Mike, We can update SunPKCS11 provider when the PKCS#11 official header files are updated with SHA3 and Hmac w/ SHA3. I agree with you on the ideal case is to have no lagging in JCA and the SunPKCS11 provider. The main rea

RFR [15] JDK-8242145, New System Properties to configure the TLS signature schemes

2020-04-03 Thread Xuelei Fan
Hi, Could I get the following update reviewed? Webrev: http://cr.openjdk.java.net/~xuelei/8242145/webrev.00/ Bug: https://bugs.openjdk.java.net/browse/JDK-8242141 CSR: https://bugs.openjdk.java.net/browse/JDK-8242145 Release-note: https://bugs.openjdk.java.net/browse/JDK-8242147 A third party'

Re: [RFR] 8166597: Crypto support for the EdDSA Signature Algorithm (JEP 339)

2020-04-03 Thread Anthony Scarpino
On 4/2/20 8:34 PM, Weijun Wang wrote: Another question: Why does getAlgorithm() of PublicKey and PrivateKey return "EdDSA" instead of "Ed25519" and "Ed448"? Do we suggest people using "EdDSA" or "Ed25519"/"Ed448" when calling KeyFactory.getInstance() andKeyPairGenerator.getInstance()? I don't

Re: [15] RFR 8172680: Support SHA-3 based Hmac algorithms

2020-04-03 Thread Valerie Peng
Hi Mike, We can update SunPKCS11 provider when the PKCS#11 official header files are updated with SHA3 and Hmac w/ SHA3. I agree with you on the ideal case is to have no lagging in JCA and the SunPKCS11 provider. The main reason for the lagging is that we need to test and make sure the add

Re: RFR 8241960: The SHA3 message digests are not thread safe when cloned

2020-04-03 Thread Valerie Peng
The updated webrev looks good. I will proceed with pre-integration testing and push the changes on your behalf once the testing is done. In the mean time, if you have any particular wording for the commit message, please send it my way. Thanks, Valerie On 4/3/2020 5:40 AM, Alexey Bakhtin wrot

Re: RFR 8241960: The SHA3 message digests are not thread safe when cloned

2020-04-03 Thread Alexey Bakhtin
Hello Valeri, Thank you for review. Please, have a look at updated patch at : https://cr.openjdk.java.net/~abakhtin/8241960/webrev.v1/ I’ve fixed your findings and renamed test class to ThreadSafetyTest. Jtreg already has ThreadSafeTest class for java.text.Normalizer functionality. Thank you

Re: RFR 8240848: ArrayIndexOutOfBoundsException buf for TextCallbackHandler

2020-04-03 Thread Weijun Wang
Ping again. > On Mar 12, 2020, at 9:21 PM, Weijun Wang wrote: > > Please take a review at > > http://cr.openjdk.java.net/~weijun/8240848/webrev.00/ > > The problem is that selection has a different meaning for a specified > optionType (the option value) and an unspecified one (the option in