Re: RFR[15] JDK-8243029: Rewrite javax/net/ssl/compatibility/Compatibility.java with a flexible interop test framework

2020-04-23 Thread Xuelei Fan
Looks good to me. Thanks, Xuelei On 4/19/2020 6:33 PM, sha.ji...@oracle.com wrote: Hi, This patch introduces a flexible test framework for supporting JSSE interop testing. This framework supports the SSL/TLS communication between not only JDK builds, but also possibly other TLS implementatio

[15] RFR JDK-8242151 Improve OID mapping and reuse among JDK security providers for aliases registration

2020-04-23 Thread Valerie Peng
Hi Max, Would you have time to review this change? The current webrev attempts to cover all security classes where hard-coded oid strings and consolidate these known oid string values into a single enum type. The changes are quite extensive, I can trim back and only cover the provider algorit

[15] RFR JDK-8242897 KeyFactory.generatePublic( x509Spec ) failed with java.security.InvalidKeyException

2020-04-23 Thread Valerie Peng
Anyone has time to help review this fix? After the support for RSASSA-PSS keys is added, when parsing the DER encoding, the key algorithm is based on the parsed algorithm oid/name. However, an exception is thrown if the parsed algorithm oid/name is neither RSA nor RSASSA-PSS. For this particula

RFR JDK-8236464 : SO_LINGER option is ignored by SSLSocket in JDK 11

2020-04-23 Thread Xuelei Fan
Hi, Could I get the following update reviewed?    http://cr.openjdk.java.net/~xuelei/8236464/webrev.00/ In the current implementation, the sending of close_notify may not respect the SO_LINGER setting in some circumstances.   With this update, the delivering of close_notify alert will conside

Re: [15] RFR: 8242929: The values of jdk.tls.namedGroups should not be case-sensitive

2020-04-23 Thread Xuelei Fan
It looks fine to me.  Thank you! Xuelei On 4/23/2020 12:43 AM, sibabrata.sa...@oracle.com wrote: Hi Xuelei, Please review the patch for, JBS: https://bugs.openjdk.java.net/browse/JDK-8242929 Webrev: http://cr.openjdk.java.net/~ssahoo/8242929/webrev.00/ This is a small fix to make named groups

Re: jdk/jdk + jdk11 : failing jtreg test security/infra/java/security/cert/CertPathValidator/certification/BuypassCA.java

2020-04-23 Thread Sean Mullan
On 4/23/20 6:33 AM, Baesken, Matthias wrote: Hello,   the test 'security/infra/java/security/cert/CertPathValidator/certification/BuypassCA.java' started failing  since last nightly tests (both in jdk/jdk and jdk11) . Looks like a certificate  has been revoked. Error is : =

jdk/jdk + jdk11 : failing jtreg test security/infra/java/security/cert/CertPathValidator/certification/BuypassCA.java

2020-04-23 Thread Baesken, Matthias
Hello, the test 'security/infra/java/security/cert/CertPathValidator/certification/BuypassCA.java' started failing since last nightly tests (both in jdk/jdk and jdk11) . Looks like a certificate has been revoked. Error is : = Received ex

[15] RFR: 8242929: The values of jdk.tls.namedGroups should not be case-sensitive

2020-04-23 Thread sibabrata.sa...@oracle.com
Hi Xuelei, Please review the patch for, JBS: https://bugs.openjdk.java.net/browse/JDK-8242929 Webrev: http://cr.openjdk.java.net/~ssahoo/8242929/webrev.00/ This is a small fix to make name