The fix looks fine to me. For consistency, you could make the same
change for null elements in the other SecureSet methods: add, remove.
--Sean
On 4/25/20 3:39 AM, Weijun Wang wrote:
Please take a review at
http://cr.openjdk.java.net/~weijun/8243592/webrev.00/
This is helpful if we do an
Hi Max,
Thanks for reviewing this~ Please find my replies inline.
On 4/25/2020 3:28 AM, Weijun Wang wrote:
OidString.java
==
1. ExtendedKeyUsage names: used to be "serverAuth", now "ServerAuth". First
letter capitalized, is this necessary?
Yes, I made a change here. Using "Serve
Yes, it can be quite a confusing scenario. Some algorithms have multiple
oids (say X) and multiple algorithm names (say Y). We need to be able to
handle all of them (X+Y). However, the separation of alias definition
for OidString and SecurityProviderConstants are intentional and I have
them sep
> On Apr 28, 2020, at 8:08 AM, Valerie Peng wrote:
>
> Yes, it can be quite a confusing scenario. Some algorithms have multiple oids
> (say X) and multiple algorithm names (say Y). We need to be able to handle
> all of them (X+Y). However, the separation of alias definition for OidString
> a
> On Apr 28, 2020, at 6:19 AM, Valerie Peng wrote:
>
> Hi Max,
>
> Thanks for reviewing this~ Please find my replies inline.
>
> On 4/25/2020 3:28 AM, Weijun Wang wrote:
>> OidString.java
>> ==
>>
>> 1. ExtendedKeyUsage names: used to be "serverAuth", now "ServerAuth". First
>>
Reading the Set spec, it looks like an NPE is still needed for add(), but
remove() can be modified.
--Max
> On Apr 27, 2020, at 10:27 PM, Sean Mullan wrote:
>
> The fix looks fine to me. For consistency, you could make the same change for
> null elements in the other SecureSet methods: add, r
