Re: RFR[15] 8242060: Add revocation checking to jarsigner

2020-05-04 Thread Weijun Wang
> On May 5, 2020, at 12:36 PM, Hai-May Chao wrote: > > > >> On May 4, 2020, at 6:01 PM, Weijun Wang wrote: >> >> >> >>> On May 5, 2020, at 3:48 AM, Hai-May Chao wrote: >>> >>> Hi Max, >>> On May 2, 2020, at 5:25 PM, Weijun Wang wrote: In jarsigner/Main, you can just

Re: RFR 8239385: KerberosTicket client name refers wrongly to sAMAccountName in AD

2020-05-04 Thread Weijun Wang
Yes, please. Thanks, Max > On May 5, 2020, at 11:58 AM, Martin Balao wrote: > > Hi Max, > > On 3/30/20 5:24 PM, Martin Balao wrote: >> >> CSR requested here: https://bugs.openjdk.java.net/browse/JDK-8241871 >> > > Now that the CSR has been approved, are we good to push? > > Thanks, >

Re: RFR[15] 8242060: Add revocation checking to jarsigner

2020-05-04 Thread Hai-May Chao
> On May 4, 2020, at 6:01 PM, Weijun Wang wrote: > > > >> On May 5, 2020, at 3:48 AM, Hai-May Chao wrote: >> >> Hi Max, >> >>> On May 2, 2020, at 5:25 PM, Weijun Wang wrote: >>> >>> In jarsigner/Main, you can just call >>> >>> pkixParameters.setRevocationEnabled(revocationCheck); >>

Re: RFR 8239385: KerberosTicket client name refers wrongly to sAMAccountName in AD

2020-05-04 Thread Martin Balao
Hi Max, On 3/30/20 5:24 PM, Martin Balao wrote: > > CSR requested here: https://bugs.openjdk.java.net/browse/JDK-8241871 > Now that the CSR has been approved, are we good to push? Thanks, Martin.-

Re: [15] RFR JDK-8242151 Improve OID mapping and reuse among JDK security providers for aliases registration

2020-05-04 Thread Weijun Wang
Do you want to add OIDs in CurveDB into KnownOIDs as well? Thanks, Max

Re: [RFR] 8166597: Crypto support for the EdDSA Signature Algorithm (JEP 339)

2020-05-04 Thread Bradford Wetmore
All minor nits, can be done later if it won't be a problem to make minor API wording tweaks. On 5/4/2020 10:17 AM, Anthony Scarpino wrote: On 2/25/20 12:49 PM, Anthony Scarpino wrote: Hi I need a code review for the EdDSA support in JEP 339.  The code builds on the existing java implemented

Re: RFR[15] 8242060: Add revocation checking to jarsigner

2020-05-04 Thread Weijun Wang
> On May 5, 2020, at 3:48 AM, Hai-May Chao wrote: > > Hi Max, > >> On May 2, 2020, at 5:25 PM, Weijun Wang wrote: >> >> In jarsigner/Main, you can just call >> >> pkixParameters.setRevocationEnabled(revocationCheck); > > Ok > >> >> Last time, you mentioned that

Re: RFR: 8244224: Implementation of JEP 381: Remove the Solaris and SPARC Ports (security)

2020-05-04 Thread sha . jiang
Hi, Generally, this patch doesn't take care of the solaris/sunos/ucrypto-related words in test summaries, code comments, configs and READMEs. E.g. test/jdk/javax/net/ssl/templates/SSLEngineTemplate.java test/jdk/sun/security/provider/MessageDigest/TestSHAClone.java

Re: RFR[15] 8242060: Add revocation checking to jarsigner

2020-05-04 Thread Hai-May Chao
Hi Max, > On May 2, 2020, at 5:25 PM, Weijun Wang wrote: > > In jarsigner/Main, you can just call > > pkixParameters.setRevocationEnabled(revocationCheck); Ok > > Last time, you mentioned that "Event.clearReportListener()" cannot be called > immediately after validation check because of

Re: [RFR] 8166597: Crypto support for the EdDSA Signature Algorithm (JEP 339)

2020-05-04 Thread Anthony Scarpino
On 2/25/20 12:49 PM, Anthony Scarpino wrote: Hi I need a code review for the EdDSA support in JEP 339.  The code builds on the existing java implemented constant time classes used for XDH and the NIST curves.  The change also adds classes to the public API to support EdDSA operations.

Re: [15] RFR: 8242335: Additional Tests for RSASSA-PSS

2020-05-04 Thread Valerie Peng
Updated webrev looks fine. Thanks, Valerie On 5/3/2020 11:27 PM, sibabrata.sa...@oracle.com wrote: Hi Valerie, Here is the updated web rev addressing the following comments. There are 7 lines of additional change added [Line: 126-133] to re-verify the signature with another Signature

Re: RFR: 8244224: Implementation of JEP 381: Remove the Solaris and SPARC Ports (security)

2020-05-04 Thread Weijun Wang
I've gone through all files. Many of them are PKCS11-related, it will be nice if Valerie can confirm my findings. src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/Config.java: Maybe we should not support $ISA at all?

RE: [PATCH] 8244199: [TestBug]: Update sun/management/jmxremote/bootstrap tests

2020-05-04 Thread Thejasvi Voniadka
Adding jmx-dev and security-dev. -Original Message- From: Thejasvi Voniadka Sent: Monday, May 4, 2020 12:56 PM To: core-libs-...@openjdk.java.net Subject: [PATCH] 8244199: [TestBug]: Update sun/management/jmxremote/bootstrap tests Hi, May I please find a sponsor for this patch? Bug:

Re: [15] RFR: 8242335: Additional Tests for RSASSA-PSS

2020-05-04 Thread sibabrata.sa...@oracle.com
Hi Valerie, Here is the updated web rev addressing the following comments. There are 7 lines of additional change added [Line: 126-133] to re-verify the signature with another Signature instance. Webrev: http://cr.openjdk.java.net/~ssahoo/8242335/webrev.01/