Re: RFR: 8244224: Implementation of JEP 381: Remove the Solaris and SPARC Ports (security)

2020-05-06 Thread Mikael Vidstedt
New webrev here: webrev: http://cr.openjdk.java.net/~mikael/webrevs/8244224/webrev.01/security/open/webrev/ incremental: http://cr.openjdk.java.net/~mikael/webrevs/8244224/webrev.01/security.incr/open/webrev/ Items yet to be resolved: * File follow-up to drop $ISA support in

Re: RFR: 8244224: Implementation of JEP 381: Remove the Solaris and SPARC Ports (security)

2020-05-06 Thread Mikael Vidstedt
> On May 5, 2020, at 7:29 PM, Weijun Wang wrote: > > > >> On May 6, 2020, at 6:51 AM, Mikael Vidstedt >> wrote: >> >> >> Max, >> >> Thank you so much for the thorough review! I’m working on an incremental >> webrev but could use some help - comments/questions inline.. >> >>> On May

Re: [15] RFR JDK-8242151 Improve OID mapping and reuse among JDK security providers for aliases registration

2020-05-06 Thread Weijun Wang
> > It seems that existing impl of PBES2Parameters class only enforces that the > KDF algo is one of the HmacSHAxxx. But it does not throw exception if the > instance is requested with "PBEWithHmacSHA256AndAES_256" and then initialized > with DER encoding containing

Re: [15] RFR JDK-8242151 Improve OID mapping and reuse among JDK security providers for aliases registration

2020-05-06 Thread Valerie Peng
Hi Max, Thanks for the review, I find your comments very useful. Please find responses inline. On 5/6/2020 5:48 AM, Weijun Wang wrote: - PBES2Parameters.java: In parseKDF(), any OID can be accepted as kdfAlgo, wonder if it would lead to unexpected result: jshell> var a =

Re: [15] RFR JDK-8242151 Improve OID mapping and reuse among JDK security providers for aliases registration

2020-05-06 Thread Valerie Peng
Sure, I can include this in. Will address in webrev.03. Thanks, Valerie On 5/5/2020 3:33 AM, Weijun Wang wrote: I am playing with keytool + BouncyCastle and generate a key pair using the sigalg "SHA3-256WITHECDSA", and `keytool -list` cannot show the signature name. So I tried 2 changes in

Re: RFR: 8231958: Test for JDK-8228825: Enhance ECDSA

2020-05-06 Thread shivangi . g . gupta
Ignore this review thread for now, I need to rework the fix. ~Shivangi On 06/05/20 11:00 PM, shivangi.g.gu...@oracle.com wrote: Hi, May I please find a sponsor for this patch? Bug: https://bugs.openjdk.java.net/browse/JDK-8231958 Description: There were few curves which were

Re: openjdk 13 + ; SunEC, secp256r1 ecc encryption

2020-05-06 Thread Anthony Scarpino
On 5/6/20 7:42 AM, jjk wrote: Dear SMEs Do openJDk versions 13 and above support EC encryption? for me secp256r1 curve is enough as it is common amongst several other platforms (non-java). Is this something natively supported (13+)? I saw various on sunec.jar, native system.load(..) etc.

openjdk 13 + ; SunEC, secp256r1 ecc encryption

2020-05-06 Thread jjk
Dear SMEs Do openJDk versions 13 and above support EC encryption? for me secp256r1 curve is enough as it is common amongst several other platforms (non-java). Is this something natively supported (13+)? I saw various on sunec.jar, native system.load(..) etc. Appreciate if someone can also

RFR: 8231958: Test for JDK-8228825: Enhance ECDSA

2020-05-06 Thread shivangi . g . gupta
Hi, May I please find a sponsor for this patch? Bug: https://bugs.openjdk.java.net/browse/JDK-8231958 Description: There were few curves which were removed from supported list as part of JDK-8228825. These can be added back to supported list with jdk.tls.namedGroups property.    

Re: [15] RFR JDK-8242151 Improve OID mapping and reuse among JDK security providers for aliases registration

2020-05-06 Thread Weijun Wang
- PBES2Parameters.java: In parseKDF(), any OID can be accepted as kdfAlgo, wonder if it would lead to unexpected result: jshell> var a = AlgorithmParameters.getInstance("PBEWithHmacSHA256AndAES_256") jshell> a.init(new PBEParameterSpec("hello".getBytes(), 100, new

[PATCH] 8244199: [TestBug]: Update sun/management/jmxremote/bootstrap tests

2020-05-06 Thread Thejasvi Voniadka
Hello, A quick follow-up on this request.. -Original Message- From: Thejasvi Voniadka Sent: Monday, May 4, 2020 12:56 PM To: core-libs-...@openjdk.java.net Subject: [PATCH] 8244199: [TestBug]: Update sun/management/jmxremote/bootstrap tests Hi, May I please find a sponsor for this