Re: [15] RFR JDK-8242151 Improve OID mapping and reuse among JDK security providers for aliases registration

2020-05-11 Thread Weijun Wang
Some files have trailing spaces. KnownOIDs.java: - Is there an order for the fields? I see they are grouped but now always ordered. - Unused "import java.security.Provider;" - 1.3.14.3.2.29 used to be an alias for SHA1withRSA, now it's not. Is this intended? - s/_/-/ in process() is now

RE: RFR: 8244199: [TestBug]: Update sun/management/jmxremote/bootstrap tests

2020-05-11 Thread Thejasvi Voniadka
Ping.. -Original Message- From: Thejasvi Voniadka Sent: Friday, May 8, 2020 6:17 AM To: core-libs-...@openjdk.java.net; jmx-...@openjdk.java.net; security-dev@openjdk.java.net Subject: RFR: 8244199: [TestBug]: Update sun/management/jmxremote/bootstrap tests Hi, May someone please sp

Re: [15] RFR JDK-8242151 Improve OID mapping and reuse among JDK security providers for aliases registration

2020-05-11 Thread Valerie Peng
Thanks for filing the bug for PBES2Parameters class. Webrev for 8242151 is updated at: http://cr.openjdk.java.net/~valeriep/8242151/webrev.03/ It addresses: - added KnownOIDs for CurveDB class - updated the KDF parsing code in PBES2Parameters class to match existing behavior - removed the St

Re: RFR: 8244224: Implementation of JEP 381: Remove the Solaris and SPARC Ports (security)

2020-05-11 Thread Valerie Peng
Incremental changes look fine. Thanks, Valerie On 5/11/2020 2:27 PM, Mikael Vidstedt wrote: New webrev fixing Basic.policy based on Valeries’s comment: webrev: http://cr.openjdk.java.net/~mikael/webrevs/8244224/webrev.03/security/open/webrev/ incremental: http://cr.openjdk.java.net/~mikael/

Re: [RFR] 8166597: Crypto support for the EdDSA Signature Algorithm (JEP 339)

2020-05-11 Thread Bradford Wetmore
Finally found the bottom of the review. ;) I'll send you minor nits (unused imports/etc.) in a separate email. src/jdk.crypto.ec/share/classes/sun/security/ec/ed/EdDSAOperations.java -- 136: Here you are calling sun.security.util.ArrayUtil.reverse() (and swap()), but you also added a

Re: RFR: 8244224: Implementation of JEP 381: Remove the Solaris and SPARC Ports (security)

2020-05-11 Thread Mikael Vidstedt
New webrev fixing Basic.policy based on Valeries’s comment: webrev: http://cr.openjdk.java.net/~mikael/webrevs/8244224/webrev.03/security/open/webrev/ incremental: http://cr.openjdk.java.net/~mikael/webrevs/8244224/webrev.03/security.incr/open/webrev/ Cheers, Mikael > On May 7, 2020, at 8:54

Re: RFR 8244674: Third-party code version check

2020-05-11 Thread Sean Mullan
Looks good to me. --Sean On 5/8/20 11:29 PM, Weijun Wang wrote: Please take a review at https://cr.openjdk.java.net/~weijun/8244674/webrev.00 I've consolidated 2 old tests into one and added a new case. Thanks, Max

Re: ECDSA Algorithms not available with jlink

2020-05-11 Thread Sean Mullan
Hi, Thanks for letting us know about this. We would like to figure out what might be causing this. However, this is not the best forum for debugging issues. Can you please file a bug at https://bugreport.java.com/bugreport/ ? Can you also attach the debug output when running with "java -Dja

ECDSA Algorithms not available with jlink

2020-05-11 Thread Michele Adduci
Hello, my name is Michele Adduci and I've freshly subscribed to this mailing list because I'm seeking for advice/help on an issue that arose during the creation of a new application and I couldn't find my answers by searching online. I'm using JDK 14.0.1 GA and trying to create a small redistribu