Re: RFR 8246193: Possible NPE in ENC-PA-REP search in AS-REQ

Thanks. Updated and pushed. --Max > On May 31, 2020, at 10:03 AM, Xuelei Fan wrote: > > Looks good to me. You may also want to update the copyright date in KDC.java. > > Xuelei > > On 5/30/2020 4:54 AM, Weijun Wang wrote: >> Please take a review at >>http://cr.openjdk.java.net/~weijun/82

Re: RFR 8246193: Possible NPE in ENC-PA-REP search in AS-REQ

Looks good to me. You may also want to update the copyright date in KDC.java. Xuelei On 5/30/2020 4:54 AM, Weijun Wang wrote: Please take a review at http://cr.openjdk.java.net/~weijun/8246193/webrev.00/ While searching for ENC-PA-REP in the PA-DATA list of AS-REQ, it's possible there

Re: RFR 8246193: Possible NPE in ENC-PA-REP search in AS-REQ

On 5/30/20 8:54 AM, Weijun Wang wrote: > Please take a review at > >http://cr.openjdk.java.net/~weijun/8246193/webrev.00/ > > While searching for ENC-PA-REP in the PA-DATA list of AS-REQ, it's possible > there is no PA-DATA at all. This could happen when preauth is turned off. > I'm not a

Re: [RFR] 8243424: Signature and SignatureSpi get parameter methods may throw null when unsupported

I wish AlgorithmParameters was actually AlgorithmIdentifier which is OID+params, but it's too late. Sigh. --Max > On May 28, 2020, at 4:22 AM, Anthony Scarpino > wrote: > > Hi, > > I need a javadoc review for a Signature/SignatureSpi parameters change that > is needed to the spec, which aff

RFR 8246193: Possible NPE in ENC-PA-REP search in AS-REQ

Please take a review at http://cr.openjdk.java.net/~weijun/8246193/webrev.00/ While searching for ENC-PA-REP in the PA-DATA list of AS-REQ, it's possible there is no PA-DATA at all. This could happen when preauth is turned off. Thanks, Max