Re: RFR 8242068: Signed JAR support for RSASSA-PSS and EdDSA

Ping again. CSR already approved and rdp1 is near... Thanks, Max > On Jun 2, 2020, at 4:07 PM, Weijun Wang wrote: > > Updated again at > > https://cr.openjdk.java.net/~weijun/8242068/webrev.02 > > Major changes this time: > > 1. Use Signed Attributes in

Re: RFR 8244148: keytool -printcert and -printcrl should support the -trustcacerts and -keystore options

Looks fine to me. For CSR, since there is already a "Note" there for these 2 options, you can add a few words about what -keystore and -trustcacerts can do. Thanks, Max > On Jun 8, 2020, at 4:01 AM, Hai-May Chao wrote: > > Updated webrev - > >

Re: RFR 8244148: keytool -printcert and -printcrl should support the -trustcacerts and -keystore options

Updated webrev - https://cr.openjdk.java.net/~hchao/8244148/webrev.02/ Thanks, Hai-May > On Jun 5, 2020, at 11:04 PM, Weijun Wang wrote: > > I still think duplicated commands in TrustedCert.java are useless. Line 104 > and line 133