Re: [EXTERNAL]Re: NullPointer in JceSecurity.getVerificationResult - Affects JDK 11.07, and JDK 12 and later.

2020-06-11 Thread Valerie Peng
Hi, John, Thanks for the reply. Yes, your understanding is correct. I expect the fix for JDK-8246613 will be backported into other releases. BTW, if you have spare time for the test provider, it'd help speeding up the fix for JDK-8246383. If not, it's ok as well. Just may take longer to get

Re: [15] RFR JDK-8246613: Choose the default SecureRandom algo based on registration ordering

2020-06-11 Thread Valerie Peng
Hi, Max, Sure, I've reverted to that old code so it should be bullet proof now. Webrev updated: http://cr.openjdk.java.net/~valeriep/8246613/webrev.04/ Will proceed with integration once pre-integration Mach5 tests finishes. Thanks for reviewing~ Valerie On 6/10/2020 11:15 PM, Weijun Wang wr

RE: [15] RFR JDK-8246031: Hang observed with coherence SSLNIOServer test

2020-06-11 Thread Prasadrao Koppula
Thanks Xuelei, updated the code accordingly. Thanks, Prasad.K >-Original Message- >From: Xuelei Fan >Sent: Thursday, June 11, 2020 9:03 PM >To: Prasadrao Koppula ; security- >d...@openjdk.java.net >Subject: Re: [15] RFR JDK-8246031: Hang observed with coherence >SSLNIOServer test > >On 6/

Re: [15] RFR JDK-8246031: Hang observed with coherence SSLNIOServer test

2020-06-11 Thread Xuelei Fan
On 6/11/2020 1:50 AM, Prasadrao Koppula wrote: http://cr.openjdk.java.net/~pkoppula/8246031/webrev.01/ I may have 8 more white spaces indent at line 449, and have 446 and 447 in one line. Otherwise, looks good to me. Need no more review from me. Thanks, Xuelei

Re: Thread leak by LdapLoginModule

2020-06-11 Thread Seán Coffey
If 8217606 is your issue, then it's fixed in JDK 11.0.8 which is due for release in mid July. regards, Sean. On 09/06/2020 22:15, Mkrtchyan, Tigran wrote: Hi all, with Java-11 we have notice a thread leak with ldap module. We use LDAP to authenticate users with username+pasword by directly ca

RE: [15] RFR JDK-8246031: Hang observed with coherence SSLNIOServer test

2020-06-11 Thread Prasadrao Koppula
Thanks for review Xuelei, Removed handleException changes. Please review the change from latest webrev[1] >+} else { >+handleException(iioe); handleException throws exception for InterruptedIOException without closing the connection. A direct conContext.fatal

Re: RFR 8244148: keytool -printcert and -printcrl should support the -trustcacerts and -keystore options

2020-06-11 Thread sha . jiang
Hi Hai-May, On 2020/6/8 04:01, Hai-May Chao wrote: Updated webrev - https://cr.openjdk.java.net/~hchao/8244148/webrev.02/ -- src/java.base/share/classes/sun/security/util/FilePaths.java Would it be better to use String.join() or even java.nio.file.Path to build the file path? -- src/java.base

Re: RFR 8245520: Provide a way to add CA certificate to cacerts during test run

2020-06-11 Thread sha . jiang
Hi Max, Thanks for your info! It looks that patch for java.base:sun.security.util.FilePaths.java is used for specifying an alternative cacerts file. But my requirement is updating the existing cacerts with given CAs. Both of the functions are useful. I'll submit a new webrev after the fix for JD