Re: [15] RFR 8247964: All log0() in com/sun/org/slf4j/internal/Logger.java should be private

2020-06-20 Thread Xuelei Fan
Looks good to me. Xuelei On 6/20/2020 7:47 AM, Weijun Wang wrote: The 3 newly added log0() methods in com/sun/org/slf4j/internal/Logger.java are declared public. This is a stupid typo. In fact, in the comment at the beginning of that class [1] I specifically pointed out they are private. He

Re: [15] RFR 8247964: All log0() in com/sun/org/slf4j/internal/Logger.java should be private

2020-06-20 Thread Roger Riggs
Looks good. Good to catch these early. Thanks, Roger On 6/20/20 10:47 AM, Weijun Wang wrote: The 3 newly added log0() methods in com/sun/org/slf4j/internal/Logger.java are declared public. This is a stupid typo. In fact, in the comment at the beginning of that class [1] I specifically pointe

[15] RFR 8247964: All log0() in com/sun/org/slf4j/internal/Logger.java should be private

2020-06-20 Thread Weijun Wang
The 3 newly added log0() methods in com/sun/org/slf4j/internal/Logger.java are declared public. This is a stupid typo. In fact, in the comment at the beginning of that class [1] I specifically pointed out they are private. Here is the patch. Noreg-trivial. diff --git a/src/java.xml.crypto/shar