Thanks for the review~
Valerie
On 8/20/2020 1:49 PM, Xuelei Fan wrote:
Looks good to me. Thanks!
Xuelei
On 8/20/2020 1:28 PM, Valerie Peng wrote:
Updated to use the "JCAUtil.getSecureRandom()" call:
http://cr.openjdk.java.net/~valeriep/8246383/webrev.01/
Thanks,
Valerie
On 8/19/2020 11:2
Looks good to me. Thanks!
Xuelei
On 8/20/2020 1:28 PM, Valerie Peng wrote:
Updated to use the "JCAUtil.getSecureRandom()" call:
http://cr.openjdk.java.net/~valeriep/8246383/webrev.01/
Thanks,
Valerie
On 8/19/2020 11:20 AM, Valerie Peng wrote:
Hi Xuelei,
Please find comments in line.
On
Updated to use the "JCAUtil.getSecureRandom()" call:
http://cr.openjdk.java.net/~valeriep/8246383/webrev.01/
Thanks,
Valerie
On 8/19/2020 11:20 AM, Valerie Peng wrote:
Hi Xuelei,
Please find comments in line.
On 8/18/2020 10:13 PM, Xuelei Fan wrote:
On 8/18/2020 2:43 PM, Valerie Peng wrote
Thanks for looking at this issue.
I had suggested the simple fix as a way to remove the NPE during
initialization, but if you think there are other places where this circular
logic could crop up again (or could be easily introduced in the future) then I
would agree an alternate fix could be b
Yes, thanks for the suggested fix. It's a good starting point. :)
Regards,
Valerie
On 8/20/2020 6:18 AM, John Gray wrote:
Thanks for looking at this issue.
I had suggested the simple fix as a way to remove the NPE during
initialization, but if you think there are other places where this circul
Please review using the java.util.Hex api in security related classes.
(The review of the API is being done on the core-libs-...@openjdk.java.net).
Within the JDK and JDK tests there are multiple implementations to
encode and decode
hexadecimal strings to byte arrays. Hex encoders and decoders
