keytool generates incorrect EC AlgorithmIdentifier

2020-08-25 Thread Anders Rundgren
The command  keytool -genkeypair -keyalg ec -keysize 256 -dname "CN=me" -keystore mycert.jks using JDK 11 generates the following signature: 220: SEQUENCE    { 222: OBJECT IDENTIFIER ecdsa-with-Sha256 (1.2.840.10045.4.3.2) 232: NULL    } 234: BIT STRING, en

Re: RFR 8252055: Use java.util.Hex encoder and decoder in java.security

2020-08-25 Thread Xuelei Fan
Looks good to me. Thanks, Xuelei On 8/20/2020 8:14 AM, Roger Riggs wrote: Please review using the java.util.Hex api in security related classes. (The review of the API is being done on the core-libs-...@openjdk.java.net). Within the JDK and JDK tests there are multiple implementations to en

Re: keytool generates incorrect EC AlgorithmIdentifier

2020-08-25 Thread Sean Mullan
On 8/25/20 12:33 PM, Anders Rundgren wrote: The command  keytool -genkeypair -keyalg ec -keysize 256 -dname "CN=me" -keystore mycert.jks using JDK 11 generates the following signature: 220: SEQUENCE    { 222: OBJECT IDENTIFIER ecdsa-with-Sha256 (1.2.840.10045.4.3.2) 232: 

Re: RFR 8252055: Use java.util.Hex encoder and decoder in java.security

2020-08-25 Thread Roger Riggs
Thanks for taking a look. Due to comments on the API itself, there are going to be some API changes mostly due to naming of classes and methods. I'll update the review when the API changes settle. Thanks, Roger On 8/25/20 4:28 PM, Xuelei Fan wrote: Looks good to me. Thanks, Xuelei On 8/20/20