On Thu, 1 Oct 2020 20:02:34 GMT, Weijun Wang wrote:
> Default algorithms are bumped to be based on PBES2 with AES-256 and SHA-256.
> Please also review the CSR at
> https://bugs.openjdk.java.net/browse/JDK-8228481.
TBD: We bumped iteration counts for PBE and HMAC to 5 and 10 when we
Default algorithms are bumped to be based on PBES2 with AES-256 and SHA-256.
Please also review the CSR at
https://bugs.openjdk.java.net/browse/JDK-8228481.
-
Commit messages:
- 8153005: Upgrade the default PKCS12 encryption/MAC algorithms
Changes:
On Thu, 17 Sep 2020 23:00:54 GMT, Weijun Wang wrote:
> This code change rewrites DerValue into a mostly immutable class and
> simplifies DerInputStream as a wrapper for a
> series of DerValues objects. DerInputBuffer is removed.
> All existing methods of DerValue and DerInputStream should still
On Wed, 30 Sep 2020 17:21:14 GMT, Brent Christian wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Address the review comments and introduce an array size check in
>> JarFile.getBytes() method itself
>
>
> Can I please get a review and a sponsor for a fix for
> https://bugs.openjdk.java.net/browse/JDK-8242882?
>
> As noted in that JBS issue, if the size of the Manifest entry in the jar
> happens to be very large (such that it exceeds
> the `Integer.MAX_VALUE`), then the current code in
On Wed, 30 Sep 2020 18:38:40 GMT, Lance Andersen wrote:
>> I think it's fine either way.
>
> If you are going to validate the message, which I probably would not, it
> would be important to make sure it document
> if the message is changed in JarFile::getBytes, that the test needs updated.
>
On Thu, 1 Oct 2020 00:13:28 GMT, Stuart Marks wrote:
> Plumb new internal static factory method to trust the array passed in,
> avoiding unnecessary copying. JMH results for
> the benchmark show about 15% improvement for the cases that were optimized,
> namely the 3 to 10 fixed arg cases.
> #
