Re: RFR: 8156071: List.of: reduce array copying during creation

2020-10-02 Thread Paul Sandoz
On Thu, 1 Oct 2020 00:13:28 GMT, Stuart Marks wrote: > Plumb new internal static factory method to trust the array passed in, > avoiding unnecessary copying. JMH results for > the benchmark show about 15% improvement for the cases that were optimized, > namely the 3 to 10 fixed arg cases. > #

Re: RFR: 8156071: List.of: reduce array copying during creation

2020-10-02 Thread Stuart Marks
On Thu, 1 Oct 2020 06:26:39 GMT, Martin Grigorov wrote: >> Plumb new internal static factory method to trust the array passed in, >> avoiding unnecessary copying. JMH results for >> the benchmark show about 15% improvement for the cases that were optimized, >> namely the 3 to 10 fixed arg

Re: RFR: 8156071: List.of: reduce array copying during creation

2020-10-02 Thread Stuart Marks
On Thu, 1 Oct 2020 00:13:28 GMT, Stuart Marks wrote: > Plumb new internal static factory method to trust the array passed in, > avoiding unnecessary copying. JMH results for > the benchmark show about 15% improvement for the cases that were optimized, > namely the 3 to 10 fixed arg cases. > #

Re: RFR: 8153005: Upgrade the default PKCS12 encryption/MAC algorithms

2020-10-02 Thread Weijun Wang
On Fri, 2 Oct 2020 18:44:48 GMT, Sean Mullan wrote: >> Default algorithms are bumped to be based on PBES2 with AES-256 and SHA-256. >> Please also review the CSR at >> https://bugs.openjdk.java.net/browse/JDK-8228481. > > test/jdk/sun/security/mscapi/VeryLongAlias.java line 51: > >> 49:

Re: RFR: 8153005: Upgrade the default PKCS12 encryption/MAC algorithms

2020-10-02 Thread Sean Mullan
On Thu, 1 Oct 2020 20:02:34 GMT, Weijun Wang wrote: > Default algorithms are bumped to be based on PBES2 with AES-256 and SHA-256. > Please also review the CSR at > https://bugs.openjdk.java.net/browse/JDK-8228481. test/lib/jdk/test/lib/security/DerUtils.java line 1: > 1: /* Is this test

Re: RFR: 8153005: Upgrade the default PKCS12 encryption/MAC algorithms

2020-10-02 Thread Sean Mullan
On Thu, 1 Oct 2020 20:02:34 GMT, Weijun Wang wrote: > Default algorithms are bumped to be based on PBES2 with AES-256 and SHA-256. > Please also review the CSR at > https://bugs.openjdk.java.net/browse/JDK-8228481. test/jdk/sun/security/mscapi/VeryLongAlias.java line 51: > 49: public

Integrated: 8239105 : Add exception for expiring Digicert root certificates to VerifyCACerts test

2020-10-02 Thread Rajan Halade
On Fri, 2 Oct 2020 16:21:47 GMT, Rajan Halade wrote: > 8239105 : Add exception for expiring Digicert root certificates to > VerifyCACerts test This pull request has now been integrated. Changeset: 123e786d Author:Rajan Halade URL: https://git.openjdk.java.net/jdk/commit/123e786d

Re: RFR: 8239105 : Add exception for expiring Digicert root certificates to VerifyCACerts test

2020-10-02 Thread Rajan Halade
On Fri, 2 Oct 2020 17:09:37 GMT, Sean Mullan wrote: > Looks good. Shouldn't we be seeing mach5 test failures from this though? I > didn't see any failures. We are still not beyond 90 days. It will start failing over the weekend. - PR: https://git.openjdk.java.net/jdk/pull/484

Re: RFR: 8239105 : Add exception for expiring Digicert root certificates to VerifyCACerts test

2020-10-02 Thread Sean Mullan
On Fri, 2 Oct 2020 16:21:47 GMT, Rajan Halade wrote: > 8239105 : Add exception for expiring Digicert root certificates to > VerifyCACerts test Looks good. Shouldn't we be seeing mach5 test failures from this though? I didn't see any failures. - Marked as reviewed by mullan

RFR: 8239105: Add exception for expiring Digicert root certificates to Ver…

2020-10-02 Thread Rajan Halade
8239105: Add exception for expiring Digicert root certificates to Ver… - Commit messages: - 8239105: Add exception for expiring Digicert root certificates to VerifyCACerts test Changes: https://git.openjdk.java.net/jdk/pull/484/files Webrev:

RFR: 8251989: Hex formatting and parsing utility

2020-10-02 Thread Roger Riggs
java.util.HexFormat utility: - Format and parse hexadecimal strings, with parameters for delimiter, prefix, suffix and upper/lowercase - Static factories and builder methods to create HexFormat copies with modified parameters. - Consistent naming of methods for conversion of byte arrays to