In the Summary and Solution sections, can you be more specific as to
what TLS versions will be supported?
Can you also show what the order of signature schemes is before and
after the change, for each TLS version? I think this would make it more
clear about what the priority of the new schemes
On Wed, 14 Oct 2020 03:51:23 GMT, Weijun Wang wrote:
>> Major points in CSR at https://bugs.openjdk.java.net/browse/JDK-8245274:
>>
>> - new sigalg "RSASSA-PSS", "EdDSA", "Ed25519" and "Ed448" can be used in
>> jarsigner
>>
>> - The ".RSA" and ".EC" block extension types (PKCS #7 SignedData in
On Wed, 14 Oct 2020 16:31:32 GMT, Lance Andersen wrote:
> Mach5 run is clean :-)
Thanks a lot Lance.
Just waiting for the CSR to get approved now.
-
PR: https://git.openjdk.java.net/jdk/pull/520
On Wed, 14 Oct 2020 14:52:29 GMT, Lance Andersen wrote:
>> Volker Simonis has refreshed the contents of this pull request, and previous
>> commits have been removed. The incremental
>> views will show differences compared to the previous content of the PR.
>
> The changes look good. Thank you f
On Mon, 12 Oct 2020 11:46:31 GMT, Volker Simonis wrote:
>> I don't believe we discuss/reference the data descriptor for a Zip entry
>> (outside of the PKWare Zip specification) so I
>> am not sure we should reference it in the javadoc.
>> Placing the sentence after "The default compression meth
On Wed, 14 Oct 2020 10:54:30 GMT, Volker Simonis wrote:
>> ### Summary
>>
>> Work around wrong usage of `ZipOutputStream.putNextEntry()` in user code
>> which can lead to the `ZipException "invalid
>> entry compressed size"`.
>> ### Motivation
>>
>> In general it is not safe to directly write
> ### Summary
>
> Work around wrong usage of `ZipOutputStream.putNextEntry()` in user code
> which can lead to the `ZipException "invalid
> entry compressed size"`.
> ### Motivation
>
> In general it is not safe to directly write a ZipEntry obtained from
> `ZipInputStream.getNextEntry()`,
> `Zi
On Tue, 13 Oct 2020 19:56:50 GMT, Lance Andersen wrote:
>> Volker Simonis has refreshed the contents of this pull request, and previous
>> commits have been removed. The incremental
>> views will show differences compared to the previous content of the PR.
>
> test/jdk/java/util/zip/CopyZipFile.
On Wed, 14 Oct 2020 10:48:55 GMT, Volker Simonis wrote:
>> test/jdk/java/util/zip/CopyZipFile.java line 104:
>>
>>> 102: // all these fields set to '-1'.
>>> 103: InputStream is = new FileInputStream(ZIP_FILE);
>>> 104: ZipInputStream zis = new ZipInputStream(is);
>>
>>