Re: RFR: 8257733: Move module-specific data from make to respective module [v2]

2020-12-15 Thread Magnus Ihse Bursie
On Thu, 10 Dec 2020 23:07:52 GMT, Naoto Sato wrote: >> Magnus Ihse Bursie has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Move to share/data, and move jdwp.spec to java.se > > Reviewed changes to `characterdata`, `charsetmapping`, `cldr`

Re: RFR: 8257733: Move module-specific data from make to respective module [v4]

2020-12-15 Thread Magnus Ihse Bursie
> A lot (but not all) of the data in make/data is tied to a specific module. > For instance, the publicsuffixlist is used by java.base, and fontconfig by > java.desktop. (A few directories, like mainmanifest, is *actually* used by > make for the whole build.) > > These data files should move t

[jdk16] Integrated: 8258419: RSA cipher buffer cleanup

2020-12-15 Thread Weijun Wang
On Tue, 15 Dec 2020 19:16:22 GMT, Weijun Wang wrote: > Some array allocation is not necessary, and the content can be cleaned. This pull request has now been integrated. Changeset: b97fe6c4 Author:Weijun Wang URL: https://git.openjdk.java.net/jdk16/commit/b97fe6c4 Stats: 89 lines

Re: RFR: 8257733: Move module-specific data from make to respective module [v3]

2020-12-15 Thread Magnus Ihse Bursie
> A lot (but not all) of the data in make/data is tied to a specific module. > For instance, the publicsuffixlist is used by java.base, and fontconfig by > java.desktop. (A few directories, like mainmanifest, is *actually* used by > make for the whole build.) > > These data files should move t

Re: [jdk16] RFR: 8258419: RSA cipher buffer cleanup

2020-12-15 Thread Valerie Peng
On Tue, 15 Dec 2020 19:16:22 GMT, Weijun Wang wrote: > Some array allocation is not necessary, and the content can be cleaned. Looks good. - Marked as reviewed by valeriep (Reviewer). PR: https://git.openjdk.java.net/jdk16/pull/26

Re: [jdk16] RFR: 8258419: RSA cipher buffer cleanup

2020-12-15 Thread Weijun Wang
On Tue, 15 Dec 2020 20:31:28 GMT, Valerie Peng wrote: > Need a noreg-xxx label since there is no regression test. `noreg-cleanup` Added. Thanks. - PR: https://git.openjdk.java.net/jdk16/pull/26

RFR: 8023980: JCE doesn't provide any class to handle RSA private key in PKCS#1

2020-12-15 Thread Valerie Peng
Can someone help review this? This change enhances RSA KeyFactory impl of SunRsaSign and SunPKCS11 providers to accept RSA keys in PKCS#1 format and encoding and translate them to provider-specific RSA keys. Updated the relevant tests with a sample PKCS#1 encoded key pair. Thanks, Valerie ---

Re: [jdk16] RFR: 8258419: RSA cipher buffer cleanup

2020-12-15 Thread Valerie Peng
On Tue, 15 Dec 2020 19:16:22 GMT, Weijun Wang wrote: > Some array allocation is not necessary, and the content can be cleaned. Need a noreg-xxx label since there is no regression test. - PR: https://git.openjdk.java.net/jdk16/pull/26

[jdk16] RFR: 8258419: RSA cipher buffer cleanup

2020-12-15 Thread Weijun Wang
Some array allocation is not necessary, and the content can be cleaned. - Commit messages: - 8258419: RSA cipher buffer cleanup Changes: https://git.openjdk.java.net/jdk16/pull/26/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk16&pr=26&range=00 Issue: https://bugs.openjd

FIPS support for JCE/JSSE

2020-12-15 Thread Jeetendra Nalawade
Hi All, Based on the search I did so far, looks like openJDK out of box, does not provide FIPS compliant security providers and to enable FIPS support, we need to use third party crypto libraries. If this assumption is correct, can I use IBM security provider like IBMJCEFIPS & IBMJSSE2 with OpenJD

[jdk16] Integrated: 8258242: Type profile pollution occurs when memory segments of different kinds are used

2020-12-15 Thread Maurizio Cimadamore
On Mon, 14 Dec 2020 14:46:41 GMT, Maurizio Cimadamore wrote: > This patch fixes a problem with type profile pollution when segments of > different kinds are used on the same memory access var handle, or on the same > `MemoryAccess` static method. > > In principle, argument profiling should ki