On Tue, 26 Jan 2021 12:34:11 GMT, Alan Hayward
wrote:
>>> AIUI, the configure line needs passing a prebuilt JavaNativeFoundation
>>> framework
>>> ie:
>>> `--with-extra-ldflags='-F
>>> /Applications/Xcode.app/Contents/SharedFrameworks/ContentDeliveryServices.framework/Versions/A/itms/java/Fram
On Sun, 17 Jan 2021 20:24:44 GMT, Martin Buchholz wrote:
> 8252412: [macos11] system dynamic libraries removed from filesystem
This pull request has now been integrated.
Changeset: c836da38
Author:Martin Buchholz
URL: https://git.openjdk.java.net/jdk/commit/c836da38
Stats: 19 lin
On Sat, 23 Jan 2021 02:03:01 GMT, Valerie Peng wrote:
>> Martin Buchholz has refreshed the contents of this pull request, and
>> previous commits have been removed. The incremental views will show
>> differences compared to the previous content of the PR.
>
> Marked as reviewed by valeriep (Rev
On Tue, 26 Jan 2021 09:23:18 GMT, Magnus Ihse Bursie wrote:
>> Anton Kozlov has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Refactor CDS disabling
>> - Redo builsys support for aarch64-darwin
>
> make/autoconf/build-aux/autoconf-confi
> Please review the implementation of JEP 391: macOS/AArch64 Port.
>
> It's heavily based on existing ports to linux/aarch64, macos/x86_64, and
> windows/aarch64.
>
> Major changes are in:
> * src/hotspot/cpu/aarch64: support of the new calling convention (subtasks
> JDK-8253817, JDK-8253818)
On Tue, 26 Jan 2021 19:33:28 GMT, Weijun Wang wrote:
>> Anton Kozlov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Revert harfbuzz changes, disable warnings for it
>
> src/java.security.jgss/share/native/libj2gss/gssapi.h line 48:
>
>
On Fri, 22 Jan 2021 17:23:12 GMT, Sean Mullan wrote:
> This change enables the XML Signature secure validation mode by default. This
> will improve out of the box security by restricting signatures that contain
> potentially unsafe content by default.
>
> Please also review the CSR: https://bu
On Mon, 25 Jan 2021 17:43:35 GMT, Phil Race wrote:
>> Anton Kozlov has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Address feedback for signature generators
>> - Enable -Wformat-nonliteral back
>
> src/java.desktop/share/native/libhar
On Tue, 26 Jan 2021 18:42:02 GMT, Anton Kozlov wrote:
>> Please review the implementation of JEP 391: macOS/AArch64 Port.
>>
>> It's heavily based on existing ports to linux/aarch64, macos/x86_64, and
>> windows/aarch64.
>>
>> Major changes are in:
>> * src/hotspot/cpu/aarch64: support of the
On Fri, 22 Jan 2021 17:23:12 GMT, Sean Mullan wrote:
> This change enables the XML Signature secure validation mode by default. This
> will improve out of the box security by restricting signatures that contain
> potentially unsafe content by default.
>
> Please also review the CSR: https://bu
> Redo for 8237578: JDK-8214339 (SSLSocketImpl wraps SocketException) appears
> to not be fully fixed
>
> This also fixes JDK-8259516: Alerts sent by peer may not be received
> correctly during TLS handshake
Clive Verghese has updated the pull request with a new target base due to a
merge or a
On Tue, 26 Jan 2021 16:35:54 GMT, Bernhard Urban-Forster
wrote:
>> @lewurm This and other harfbuzz changes came from MS, could you please
>> comment here ?
>
> This looks like a merge fix mistake:
> https://github.com/openjdk/jdk/commit/051357ef977ecab77fa9b2b1e61f94f288e716f9#diff-e3815f37244
On 2021-01-26 04:44, Magnus Ihse Bursie wrote:
On 2021-01-26 13:09, Vladimir Kempik wrote:
On Tue, 26 Jan 2021 12:02:02 GMT, Alan Hayward
wrote:
AIUI, the configure line needs passing a prebuilt
JavaNativeFoundation framework
ie:
`--with-extra-ldflags='-F
/Applications/Xcode.app/Contents
> Please review the implementation of JEP 391: macOS/AArch64 Port.
>
> It's heavily based on existing ports to linux/aarch64, macos/x86_64, and
> windows/aarch64.
>
> Major changes are in:
> * src/hotspot/cpu/aarch64: support of the new calling convention (subtasks
> JDK-8253817, JDK-8253818)
On Mon, 25 Jan 2021 22:27:25 GMT, Rajan Halade wrote:
>> Xue-Lei Andrew Fan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Update copyright years to 2021
>
> Marked as reviewed by rhalade (Reviewer).
Hi Bernd,
I agree with you that Sy
> Redo for 8237578: JDK-8214339 (SSLSocketImpl wraps SocketException) appears
> to not be fully fixed
>
> This also fixes JDK-8259516: Alerts sent by peer may not be received
> correctly during TLS handshake
Clive Verghese has updated the pull request incrementally with one additional
commit s
On Mon, 25 Jan 2021 17:08:45 GMT, Fernando Guallini
wrote:
> Fixing manual Test
> "ws/open/test/jdk/sun/security/tools/jarsigner/compatibility/Compatibility.java".
> It was not handling "weak algorithm" warning during jarsigner output
> verification
This pull request has now been integrated.
On Tue, 26 Jan 2021 09:06:57 GMT, Fernando Guallini
wrote:
>> Fixing manual Test
>> "ws/open/test/jdk/sun/security/tools/jarsigner/compatibility/Compatibility.java".
>> It was not handling "weak algorithm" warning during jarsigner output
>> verification
>
> Fernando Guallini has updated the p
On Tue, 26 Jan 2021 16:07:19 GMT, Vladimir Kempik wrote:
>> src/java.desktop/share/native/libharfbuzz/hb-common.h line 113:
>>
>>> 111:
>>> 112: #define HB_TAG(c1,c2,c3,c4)
>>> ((hb_tag_t)uint32_t)(c1)&0xFF)<<24)|(((uint32_t)(c2)&0xFF)<<16)|(((uint32_t)(c3)&0xFF)<<8)|((uint32_t)(c4)&0xFF))
On Mon, 25 Jan 2021 17:43:22 GMT, Phil Race wrote:
>> Anton Kozlov has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Address feedback for signature generators
>> - Enable -Wformat-nonliteral back
>
> src/java.desktop/share/native/libhar
On Mon, 25 Jan 2021 10:00:20 GMT, Andrew Haley wrote:
>> I like the suggestion. For the defense, new functions were made this way
>> intentionally, to match existing `pass_int`, `pass_long`,.. I take your
>> comment as a blessing to fix all of them. But I feel that refactoring of
>> existing c
> Please review the implementation of JEP 391: macOS/AArch64 Port.
>
> It's heavily based on existing ports to linux/aarch64, macos/x86_64, and
> windows/aarch64.
>
> Major changes are in:
> * src/hotspot/cpu/aarch64: support of the new calling convention (subtasks
> JDK-8253817, JDK-8253818)
On Mon, 25 Jan 2021 19:12:17 GMT, Coleen Phillimore wrote:
>> I've tried to do something like this initially. The idea was to use Write in
>> VM state and Exec in Java and Native states. However, for example, JIT runs
>> in the Native state and needs Write access. So instead, W^X is managed on
On 2021-01-26 13:09, Vladimir Kempik wrote:
On Tue, 26 Jan 2021 12:02:02 GMT, Alan Hayward
wrote:
AIUI, the configure line needs passing a prebuilt JavaNativeFoundation framework
ie:
`--with-extra-ldflags='-F
/Applications/Xcode.app/Contents/SharedFrameworks/ContentDeliveryServices.framework
On Tue, 26 Jan 2021 12:06:28 GMT, Vladimir Kempik wrote:
> > AIUI, the configure line needs passing a prebuilt JavaNativeFoundation
> > framework
> > ie:
> > `--with-extra-ldflags='-F
> > /Applications/Xcode.app/Contents/SharedFrameworks/ContentDeliveryServices.framework/Versions/A/itms/java/Fr
On Tue, 26 Jan 2021 12:02:02 GMT, Alan Hayward
wrote:
> AIUI, the configure line needs passing a prebuilt JavaNativeFoundation
> framework
> ie:
> `--with-extra-ldflags='-F
> /Applications/Xcode.app/Contents/SharedFrameworks/ContentDeliveryServices.framework/Versions/A/itms/java/Frameworks/'`
On Tue, 26 Jan 2021 09:23:23 GMT, Magnus Ihse Bursie wrote:
>> Anton Kozlov has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Refactor CDS disabling
>> - Redo builsys support for aarch64-darwin
>
> Changes requested by ihse (Reviewer).
On Tue, 26 Jan 2021 11:31:18 GMT, Anton Kozlov wrote:
>> This could be a follow-up RFE.
>
> I assume a WXVerifier class that tracks W^X mode in debug mode and does
> nothing in release mode. I've considered to do this, it's relates to small
> inefficiencies, while this patch brings zero overhea
On Mon, 25 Jan 2021 14:40:42 GMT, Coleen Phillimore wrote:
>> src/hotspot/share/runtime/thread.hpp line 915:
>>
>>> 913: verify_wx_state(WXExec);
>>> 914: }
>>> 915: };
>>
>> Rather than add all this to thread.hpp, can you make a wxVerifier.hpp and
>> just add the class instance as
On Mon, 25 Jan 2021 22:57:04 GMT, Hai-May Chao wrote:
>> Fernando Guallini has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> add bugid and missing space
>
> Change copyright year to 2021
Thanks for the review
-
PR: https://g
On Sat, 23 Jan 2021 07:55:09 GMT, Alan Bateman wrote:
> We should create a separate issue to rename them and get rid of the copying
> in the make file.
I opened https://bugs.openjdk.java.net/browse/JDK-8260406.
-
PR: https://git.openjdk.java.net/jdk/pull/1611
On Mon, 25 Jan 2021 19:38:16 GMT, Anton Kozlov wrote:
>> Please review the implementation of JEP 391: macOS/AArch64 Port.
>>
>> It's heavily based on existing ports to linux/aarch64, macos/x86_64, and
>> windows/aarch64.
>>
>> Major changes are in:
>> * src/hotspot/cpu/aarch64: support of the
> Fixing manual Test
> "ws/open/test/jdk/sun/security/tools/jarsigner/compatibility/Compatibility.java".
> It was not handling "weak algorithm" warning during jarsigner output
> verification
Fernando Guallini has updated the pull request incrementally with one
additional commit since the last
On Mon, 25 Jan 2021 19:38:16 GMT, Anton Kozlov wrote:
>> Please review the implementation of JEP 391: macOS/AArch64 Port.
>>
>> It's heavily based on existing ports to linux/aarch64, macos/x86_64, and
>> windows/aarch64.
>>
>> Major changes are in:
>> * src/hotspot/cpu/aarch64: support of the
34 matches
Mail list logo